JCR-4354: VFS (commons-vfs) based FileSystem for VFS backend based Persistence Manager #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reschke
reviewed
Aug 10, 2018
| * Creates a {@link FileSystemManager} instance. | ||
| * @return a {@link FileSystemManager} instance. | ||
| * @throws RepositoryException if an error occurs creating the manager. | ||
| */ |
There was a problem hiding this comment.
javadoc error here because of different exception being thrown
| * when building a {@link FileSystemOptions} using {@link DelegatingFileSystemOptionsBuilder}. | ||
| * @return {@link FileSystemOptions} instance which is used when resolving the {@link #baseFolder} during the initialization | ||
| * @throws RepositoryException if any file system exception occurs | ||
| */ |
There was a problem hiding this comment.
javadoc error here because of different exception being thrown
|
Thanks @reschke ! I've just fixed the javadoc errors and verified it by generating javadocs locally with |
asfgit
pushed a commit
that referenced
this pull request
Aug 30, 2018
…rsistence Manager (patch by Woonsan Ko from #60) git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1839660 13f79535-47bb-0310-9956-ffa450edef68
|
Closing as it's merged to the trunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've made a pull request and I'd like to ask for your reviews.
As described in https://issues.apache.org/jira/browse/JCR-4354, this PR implements
VFSFileSystemwith a full unit test which behaves equivalently toLocalFileSystemwith a difference that the former uses Commons VFS2 library to access various backends such as SFTP server, instead of local file system.For my own demonstration purpose, I also created an example project which shows how to use this
VFSFileSystemforversioningwith an SFTP backend with instructions:Could someone review the PR and merge it if okay?
Thanks in advance,
Woonsan