refactor: Split schema module to multi file module #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close apache#981 - `Schema` and `SchemaBuilder` are kept in `schema/mod.rs` - All other individual functions (along with the tests) are moved into a new file. Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
xxchan/confident-swift
branch
from
2eb3193 to
afd4264
Compare
Member
Author
liurenjie1024
approved these changes
Feb 24, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @xxchan for fixing this, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #981
SchemaandSchemaBuilderare kept inschema/mod.rs