fix(s3): path-style-access means no virtual-host #944
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-thiel
approved these changes
Feb 4, 2025
Collaborator
c-thiel
left a comment
c-thiel
left a comment
There was a problem hiding this comment.
That's my bad apparently. We just noticed it now as pretty much all S3 implementations support path style access.
cmcarthur
pushed a commit
to cmcarthur/iceberg-rust
that referenced
this pull request
Mar 11, 2025
Hi, I noticed that this boolean check was inverted, it applied virtual host style access if path style access was true and vice-versa.
chenzl25
pushed a commit
to risingwavelabs/iceberg-rust
that referenced
this pull request
Mar 20, 2025
Hi, I noticed that this boolean check was inverted, it applied virtual host style access if path style access was true and vice-versa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that this boolean check was inverted, it applied virtual host style access if path style access was true and vice-versa.