feat: add DataFileWriter tests for schema and partition
#768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanc-n
changed the title
DataFileWriter test for schema and partitionDataFileWriter tests for schema and partition
Fokko
previously approved these changes
Dec 9, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This looks good, thanks @jonathanc-n for adding this 👍
Contributor
|
@jonathanc-n Could you rebase the PR? I'll merge it right away after that 👍 |
Contributor
Author
|
@Fokko Sorry for the wait, was on a break. Merge errors should be fixed! |
Xuanwo
approved these changes
Dec 16, 2024
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @jonathanc-n for working on this and @Fokko's review. Let's move!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #726
Added
DataFileWritertests for schema and partition