Add Spark for integration tests #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-spark
branch
5 times, most recently
from
4d1ad16 to
6473d27
Compare
Contributor
Author
|
@Xuanwo Thanks, let's get this in 🎉 |
xxchan
reviewed
Dec 16, 2024
Member
xxchan
left a comment
xxchan
left a comment
There was a problem hiding this comment.
Why not using standard spark image? like https://iceberg.apache.org/spark-quickstart/#docker-compose 👀
Have a separate Dockerfile might be hard to maintain and slow to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be good to add Spark to easily generate cases for integration tests. This way we can create tables with positional deletes, branches/tags, deletion vectors, etc.
Maybe we could also avoid adding binary files to the repository, e.g. #765.