Skip to content

feat: support arrow_struct_to_iceberg_struct #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 27, 2025
Merged

feat: support arrow_struct_to_iceberg_struct #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b1af884
add arrow_struct_to_iceberg_struct
ZENOTME Nov 28, 2024
81e34d2
use visitor pattern
ZENOTME Dec 4, 2024
44fd1e0
refine visitor design
ZENOTME Dec 11, 2024
e043e1f
add todo comment
ZENOTME Dec 11, 2024
e9e3cd7
fix typos
ZENOTME Dec 11, 2024
32625e8
use field nullable instead of array nullable
ZENOTME Dec 11, 2024
b70e347
init SchemaWithPartnerVisitor design
ZENOTME Dec 16, 2024
6bcc840
refine SchemaWithPartnerVisitor design
ZENOTME Feb 10, 2025
3e958e2
refine
ZENOTME Feb 24, 2025
df3dd40
fix rebase
ZENOTME Feb 24, 2025
6ddf160
mark private function
ZENOTME Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/iceberg/src/arrow/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@ pub use schema::*;
mod reader;
pub(crate) mod record_batch_projector;
pub(crate) mod record_batch_transformer;

mod value;
pub use reader::*;
pub use value::*;
2 changes: 1 addition & 1 deletion crates/iceberg/src/arrow/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ pub fn arrow_type_to_type(ty: &DataType) -> Result<Type> {

const ARROW_FIELD_DOC_KEY: &str = "doc";

fn get_field_id(field: &Field) -> Result<i32> {
pub(super) fn get_field_id(field: &Field) -> Result<i32> {
if let Some(value) = field.metadata().get(PARQUET_FIELD_ID_META_KEY) {
return value.parse::<i32>().map_err(|e| {
Error::new(
Expand Down
Loading
Loading