docs: Add CONTRIBUTING and finish project setup #7
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
| @@ -0,0 +1,8 @@ | |||
| # Change Log | |||
There was a problem hiding this comment.
It is up to the individual projects, what they prefer. What I do with PyIceberg is use the GitHub milestones to keep track of what's being included in a version. You can link both issues and PRs to the milestone, and that works well for me.
There was a problem hiding this comment.
Github ecosystem like dependabot will read changelog.md to provide more information for users, for example:
And I plan to utilize GitHub's built-in release note generator, which is based on pull requests, to assist us in creating the changelog. This should result in a minimal maintenance burden.
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
|
@Fokko, PTAL, thanks! |
Signed-off-by: Xuanwo <[email protected]>
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
Just a few small wording updates but other than that it LGTM
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Co-authored-by: Eduard Tudenhoefner <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
|
Hi, @nastra, all comments have been addressed, PTAL. Thanks! |
|
cc @Fokko, would you like to take another look? Thanks. |
|
Thank you @Xuanwo for the PR, and @liurenjie1024, @ConeyLiu, @jackwener, @ZENOTME, and @nastra for the reviews! Great to see so many people chiming in here |
## What changes are included in this PR? We had some failures in the Pyiceberg repo with the hive docker file here: apache/iceberg-python#2697, so I'm porting this over here. The HMS test Dockerfile was using a deprecated `openjdk:8-jre-slim` base image that has very **recently** been removed from Docker Hub, causing build failures: ``` #7 ERROR: docker.io/library/openjdk:8-jre-slim: not found ``` Simplified the Dockerfile to use apache/hive:3.1.3 as the base image directly, also eliminating the multi-stage build pattern. Which removes the dependency on a deprecated OpenJDK image and will use what's included in hive, and maintains the same functionality for HMS integration tests. Inspired by [](https://github.com/trinodb/docker-images/blob/master/testing/hive4.0-hive/Dockerfile)<https://github.com/trinodb/docker-images/blob/master/testing/hive4.0-hive/Dockerfile>
7 participants
This PR will add CONTRIBUTING guide for this project and finish the project setup works.
This PR will also close #10