feat: exposing delete files in task #625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxhZs
force-pushed
the
xxh/add-delete-schema
branch
from
3333aa6 to
dfccd0e
Compare
Contributor
|
I'm hesitating to expose this for now as it's inpractical to handle deletion file without filter. |
Contributor
|
@xxhZs Thanks for working on this, and I agree with @liurenjie1024 that this is a partial PR. I hope you don't mind closing this one in favor of #652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to support mor based on iceberg-rust,
And based on some of the comments in this pr, I exposed sequence_number and equality_ids.
And removes the restriction on data in manifest_list.