feat(reader): Add Date32 support to RecordBatchTransformer create_column #1792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbutrovich
changed the title
mbutrovich
changed the title
Contributor
Author
|
Seems like an environmental CI failure, if you can rerun that job @liurenjie1024. Thank you! |
Xuanwo
approved these changes
Oct 28, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Iceberg Java has a test that does a schema change requires the
RecordBatchTransformerto add a Date32 column, which it currently does not support.What changes are included in this PR?
Add match arms for
Date32type increate_column.Are these changes tested?
New test that mirrors Iceberg Java's
TestSelect.readAndWriteWithBranchAfterSchemaChange