refine: refine manifest_evaluator to reject not explicitly #1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
force-pushed
the
manifest_eval
branch
2 times, most recently
from
c587593 to
a63cc2e
Compare
Contributor
Author
| /// `ManifestEvaluator` is not support to evaluate predicate with `not` operator. | ||
| /// This function requires that caller pass the predicate has been rewritten. Otherwise, | ||
| /// it will return unexpected error when evaluating the predicate. | ||
| pub(crate) fn new_without_rewrite_not(partition_filter: BoundPredicate) -> Self { |
Contributor
There was a problem hiding this comment.
Instead of renaming constructor, how about add a new builder function like following:
pub(crate) fn with_rewrite_not(self, rewrite: bool) {
...
}Also we should add some tests to cover rewriting not
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @ZENOTME for this pr, LGTM! Just one minor nit.
liurenjie1024
approved these changes
Jun 27, 2025
Contributor
|
Nice one @ZENOTME Thanks for working on this 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1355
What changes are included in this PR?
As discuss in #1355 (comment) , this pr change to:
Are these changes tested?