Add support for update_table() function in Sql Catalog #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Takes in a TableCommit object and evaluates requirements with respect to current table metadata. - Generates a new metadata file based on updates provided. - Writes the new metadata file and atomically tries to commit into the SQL database. - Added test for a simple append - More tests (needed) - Upgrade table version - Update sort order - Alter schema - Update partition spec
Contributor
|
Does this already exist in #862 ? |
Author
|
@kyteware I didn't see the other PR. It doesn't look merged yet. How can I help to review/merge it ? |
Address CI error for formatting
Address CI error for formatting Address clippy error
Contributor
|
@gsoundar Sorry I didn't see this! I believe this is still the status on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?