Track: fix minimal version of dependencies

[ZENOTME]

Context: #987 (comment)

• tap
• faststr
• metainfo
• linkedbytes

After this issue resolve, we can remove the specific upgrade code in msrv:

iceberg-rust/.github/workflows/ci.yml

Line 154 in 1a2a8c8

cargo update tap faststr metainfo linkedbytes

[Xuanwo]

tap looks like an unmaintained crate. Who is relying on it? Can we have it removed?

[Xuanwo]

Most crates are maintained by @PureWhiteWu. I have contacted him and will find a way to get them fixed.

[ZENOTME]

Most crates are maintained by @PureWhiteWu. I have contacted him and will find a way to get them fixed.

Thanks @Xuanwo!

[xxchan]

tap looks like an unmaintained crate. Who is relying on it? Can we have it removed?

It's bitvec, which is also unmaintained. (very popular though)

[xxchan]

bitvec is only used by iceberg::spec::values::Struct, and its usage looks not very necessary.
What about

pub struct Struct {
    /// Vector to store the field values
    fields: Vec<Literal>,
    /// Null bitmap
    null_bitmap: BitVec,
}

// change to

pub struct Struct {
    /// Vector to store the field values
    fields: Vec<Option<Literal>>,
}

to remove tap/bitvec?

[Xuanwo]

bitvec is only used by iceberg::spec::values::Struct, and its usage looks not very necessary. What about

pub struct Struct {
/// Vector to store the field values
fields: Vec,
/// Null bitmap
null_bitmap: BitVec,
}

// change to

pub struct Struct {
/// Vector to store the field values
fields: Vec<Option>,
}
to remove tap/bitvec?

I suppport this idea. Using BitVec here is a bit over-optimized.

[xxchan]

Regarding faststr/metainfo/linkedbytes, perhaps we can upgrade pilota/volo-thrift. But their latest versions are using edition2024, which requires 1.85 (We are currently 1.84).

[Xuanwo]

Hi, hive_metastore 0.2 is now released which brings latest pilota and volo-thrift. But this version will need edition 2024 too, we will need to hold for a while.

[liurenjie1024]

I think we could close this issue for now? #1209 has added minimum deps in our Cargo.toml.

[Xuanwo]

I think we could close this issue for now? #1209 has added minimum deps in our Cargo.toml.

Nice!