Skip to content

Conversation

@MehulBatra
Copy link
Contributor

@MehulBatra MehulBatra commented Jul 1, 2024

This PR introduces a make clean command in the Makefile to automate the removal of old cached files. The make clean command will find and delete files with specific extensions that are typically generated during the Cython build process.

  • Make clean utility
  • Mkdocs change

closes: #875

@MehulBatra MehulBatra mentioned this pull request Jul 1, 2024
@MehulBatra MehulBatra requested a review from ndrluis July 2, 2024 08:07
@MehulBatra
Copy link
Contributor Author

@Fokko do see when you get a chance, waiting for your feedback too!

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MehulBatra Thanks for working on this, it looks great:

make clean
Cleaning up Cython and Python cached files
Deleting ./pyiceberg/avro/decoder_fast.cpython-312-darwin.so
Deleting ./pyiceberg/avro/decoder_fast.cpython-39-darwin.so
Deleting ./pyiceberg/avro/decoder_fast.cpython-310-darwin.so
Deleting ./tests/integration/__pycache__/test_reads.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/integration/__pycache__/test_snapshot_operations.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/integration/__pycache__/test_rest_manifest.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/integration/__pycache__/test_add_files.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/integration/__pycache__/test_partition_evolution.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/integration/__pycache__/test_inspect_table.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/integration/__pycache__/test_deletes.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/integration/__pycache__/test_partitioning_key.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/integration/__pycache__/test_rest_schema.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/integration/test_writes/__pycache__/test_partitioned_writes.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/integration/test_writes/__pycache__/utils.cpython-310.pyc
Deleting ./tests/integration/test_writes/__pycache__/test_writes.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/catalog/__pycache__/test_base.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/catalog/__pycache__/test_glue.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/catalog/__pycache__/test_sql.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/catalog/__pycache__/test_dynamodb.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/catalog/__pycache__/test_hive.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/catalog/__pycache__/test_rest.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/io/__pycache__/test_pyarrow.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/io/__pycache__/test_io.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/io/__pycache__/test_pyarrow_visitor.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/io/__pycache__/test_fsspec.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/io/__pycache__/test_pyarrow_stats.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_schema_conversion.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_decimal.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_singleton.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_config.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_bin_packing.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_datetime.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_concurrent.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_lazydict.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_manifest.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_deprecated.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/utils/__pycache__/test_truncate.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/__pycache__/test_typedef.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/__pycache__/test_conversions.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/__pycache__/test_schema.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/__pycache__/conftest.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/__pycache__/test_transforms.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/__pycache__/test_types.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/__pycache__/test_version.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/__pycache__/test_serializers.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/cli/__pycache__/test_console.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/cli/__pycache__/test_output.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/avro/__pycache__/test_encoder.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/avro/__pycache__/test_writer.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/avro/__pycache__/test_file.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/avro/__pycache__/test_resolver.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/avro/__pycache__/test_decoder.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/avro/__pycache__/test_reader.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/table/__pycache__/test_refs.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/table/__pycache__/test_metadata.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/table/__pycache__/test_snapshots.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/table/__pycache__/test_name_mapping.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/table/__pycache__/test_sorting.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/table/__pycache__/test_partitioning.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/table/__pycache__/test_init.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/expressions/__pycache__/test_projection.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/expressions/__pycache__/test_visitors.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/expressions/__pycache__/test_literals.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/expressions/__pycache__/test_parser.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/expressions/__pycache__/test_expressions.cpython-310-pytest-7.4.4.pyc
Deleting ./tests/expressions/__pycache__/test_evaluator.cpython-310-pytest-7.4.4.pyc
Deleting ./pyiceberg/catalog/__pycache__/glue.cpython-310.pyc
Deleting ./pyiceberg/catalog/__pycache__/hive.cpython-310.pyc
Deleting ./pyiceberg/catalog/__pycache__/rest.cpython-310.pyc
Deleting ./pyiceberg/catalog/__pycache__/sql.cpython-310.pyc
Deleting ./pyiceberg/catalog/__pycache__/dynamodb.cpython-310.pyc
Deleting ./pyiceberg/catalog/__pycache__/noop.cpython-310.pyc
Deleting ./pyiceberg/catalog/__pycache__/__init__.cpython-310.pyc
Deleting ./pyiceberg/io/__pycache__/pyarrow.cpython-310.pyc
Deleting ./pyiceberg/io/__pycache__/fsspec.cpython-310.pyc
Deleting ./pyiceberg/io/__pycache__/__init__.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/bin_packing.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/schema_conversion.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/config.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/truncate.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/deprecated.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/singleton.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/datetime.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/concurrent.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/lazydict.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/parsing.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/decimal.cpython-310.pyc
Deleting ./pyiceberg/utils/__pycache__/__init__.cpython-310.pyc
Deleting ./pyiceberg/__pycache__/typedef.cpython-310.pyc
Deleting ./pyiceberg/__pycache__/conversions.cpython-310.pyc
Deleting ./pyiceberg/__pycache__/schema.cpython-310.pyc
Deleting ./pyiceberg/__pycache__/transforms.cpython-310.pyc
Deleting ./pyiceberg/__pycache__/serializers.cpython-310.pyc
Deleting ./pyiceberg/__pycache__/exceptions.cpython-310.pyc
Deleting ./pyiceberg/__pycache__/types.cpython-310.pyc
Deleting ./pyiceberg/__pycache__/partitioning.cpython-310.pyc
Deleting ./pyiceberg/__pycache__/manifest.cpython-310.pyc
Deleting ./pyiceberg/__pycache__/__init__.cpython-310.pyc
Deleting ./pyiceberg/cli/__pycache__/output.cpython-310.pyc
Deleting ./pyiceberg/cli/__pycache__/console.cpython-310.pyc
Deleting ./pyiceberg/cli/__pycache__/__init__.cpython-310.pyc
Deleting ./pyiceberg/avro/codecs/__pycache__/codec.cpython-310.pyc
Deleting ./pyiceberg/avro/codecs/__pycache__/snappy_codec.cpython-310.pyc
Deleting ./pyiceberg/avro/codecs/__pycache__/deflate.cpython-310.pyc
Deleting ./pyiceberg/avro/codecs/__pycache__/zstandard_codec.cpython-310.pyc
Deleting ./pyiceberg/avro/codecs/__pycache__/bzip2.cpython-310.pyc
Deleting ./pyiceberg/avro/codecs/__pycache__/__init__.cpython-310.pyc
Deleting ./pyiceberg/avro/__pycache__/resolver.cpython-310.pyc
Deleting ./pyiceberg/avro/__pycache__/encoder.cpython-310.pyc
Deleting ./pyiceberg/avro/__pycache__/reader.cpython-310.pyc
Deleting ./pyiceberg/avro/__pycache__/file.cpython-310.pyc
Deleting ./pyiceberg/avro/__pycache__/writer.cpython-310.pyc
Deleting ./pyiceberg/avro/__pycache__/decoder.cpython-310.pyc
Deleting ./pyiceberg/avro/__pycache__/__init__.cpython-310.pyc
Deleting ./pyiceberg/table/__pycache__/name_mapping.cpython-310.pyc
Deleting ./pyiceberg/table/__pycache__/refs.cpython-310.pyc
Deleting ./pyiceberg/table/__pycache__/metadata.cpython-310.pyc
Deleting ./pyiceberg/table/__pycache__/sorting.cpython-310.pyc
Deleting ./pyiceberg/table/__pycache__/snapshots.cpython-310.pyc
Deleting ./pyiceberg/table/__pycache__/__init__.cpython-310.pyc
Deleting ./pyiceberg/expressions/__pycache__/visitors.cpython-310.pyc
Deleting ./pyiceberg/expressions/__pycache__/literals.cpython-310.pyc
Deleting ./pyiceberg/expressions/__pycache__/parser.cpython-310.pyc
Deleting ./pyiceberg/expressions/__pycache__/__init__.cpython-310.pyc
Deleting ./vendor/hive_metastore/__pycache__/ThriftHiveMetastore.cpython-310.pyc
Deleting ./vendor/hive_metastore/__pycache__/ttypes.cpython-310.pyc
Deleting ./vendor/hive_metastore/__pycache__/__init__.cpython-310.pyc
Deleting ./vendor/fb303/__pycache__/FacebookService.cpython-310.pyc
Deleting ./vendor/fb303/__pycache__/ttypes.cpython-310.pyc
Deleting ./vendor/fb303/__pycache__/__init__.cpython-310.pyc
Deleting ./tests/integration/__pycache__
Deleting ./tests/integration/test_writes/__pycache__
Deleting ./tests/catalog/__pycache__
Deleting ./tests/io/__pycache__
Deleting ./tests/utils/__pycache__
Deleting ./tests/__pycache__
Deleting ./tests/cli/__pycache__
Deleting ./tests/avro/__pycache__
Deleting ./tests/table/__pycache__
Deleting ./tests/expressions/__pycache__
Deleting ./pyiceberg/catalog/__pycache__
Deleting ./pyiceberg/io/__pycache__
Deleting ./pyiceberg/utils/__pycache__
Deleting ./pyiceberg/__pycache__
Deleting ./pyiceberg/cli/__pycache__
Deleting ./pyiceberg/avro/codecs/__pycache__
Deleting ./pyiceberg/avro/__pycache__
Deleting ./pyiceberg/table/__pycache__
Deleting ./pyiceberg/expressions/__pycache__
Deleting ./vendor/hive_metastore/__pycache__
Deleting ./vendor/fb303/__pycache__

@Fokko Fokko merged commit 52b2548 into apache:main Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add make clean option

3 participants