Skip to content

fix: update all namespace properties in update_namespace_properties #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2024
Merged

fix: update all namespace properties in update_namespace_properties #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cdd9ad
fix update namespace properties bug
ranli Jun 30, 2024
411d198
resolve comments
ranli Jun 30, 2024
db85856
resolve comment
ranli Jun 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions pyiceberg/catalog/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,11 +673,16 @@ def update_namespace_properties(
IcebergNamespaceProperties.property_key.in_(set(updates.keys())),
)
session.execute(delete_stmt)
insert_stmt = insert(IcebergNamespaceProperties)
for property_key, property_value in updates.items():
insert_stmt = insert_stmt.values(
catalog_name=self.name, namespace=namespace_str, property_key=property_key, property_value=property_value
)
insert_stmt_values = [
{
IcebergNamespaceProperties.catalog_name: self.name,
IcebergNamespaceProperties.namespace: namespace_str,
IcebergNamespaceProperties.property_key: property_key,
IcebergNamespaceProperties.property_value: property_value,
}
for property_key, property_value in updates.items()
]
insert_stmt = insert(IcebergNamespaceProperties).values(insert_stmt_values)
session.execute(insert_stmt)
session.commit()
return properties_update_summary
7 changes: 6 additions & 1 deletion tests/catalog/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,7 +1172,12 @@ def test_update_namespace_properties(catalog: SqlCatalog, namespace: str) -> Non
assert k in update_report.missing
else:
assert k in update_report.removed
assert "updated test description" == catalog.load_namespace_properties(namespace)["comment"]
assert catalog.load_namespace_properties(namespace) == {
"comment": "updated test description",
"test_property4": "4",
"test_property5": "5",
"location": f"{warehouse_location}/{namespace}.db",
}


@pytest.mark.parametrize(
Expand Down