Skip to content

Add create_namespace_if_not_exists method #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2024
Merged

Add create_namespace_if_not_exists method #725

merged 1 commit into from
May 15, 2024

Conversation

@ndrluis
Copy link
Collaborator

@ndrluis ndrluis commented May 10, 2024

Resolves #709

@ndrluis ndrluis force-pushed the namespace-exists branch from 19d42db to 26e55be Compare May 10, 2024 22:02
@sungwy
Copy link
Collaborator

sungwy commented May 13, 2024

Hi @ndrluis thank you for working on this PR.

What are your thoughts on aligning the implementation with the way create_table_if_not_exists method is currently implemented in the abstract base class Catalog? The benefit I see with this approach is that we will only have to implement it once in the abstract base class, instead of having to make the changes across different catalog implementations.

@ndrluis ndrluis force-pushed the namespace-exists branch from 26e55be to 3cd4355 Compare May 13, 2024 13:25
@ndrluis ndrluis changed the title Enable exception suppression during namespace creation @ndrluis Add create_namespace_if_not_exists method May 13, 2024
@ndrluis ndrluis changed the title @ndrluis Add create_namespace_if_not_exists method Add create_namespace_if_not_exists method May 13, 2024
@ndrluis
Copy link
Collaborator Author

ndrluis commented May 13, 2024

@syun64 Thank you for your review. I have made the requested change!

sungwy
sungwy approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@sungwy sungwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

HonahX
HonahX approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this method. @ndrluis

@HonahX HonahX merged commit a268e5b into apache:main May 15, 2024
@ndrluis ndrluis deleted the namespace-exists branch May 16, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sungwy sungwy sungwy approved these changes

@HonahX HonahX HonahX approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

create namespace if not exist

3 participants

@ndrluis @sungwy @HonahX