Support CreateTableTransaction for HiveCatalog #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on_for_hive_and_sql
4 tasks
Fokko
reviewed
May 29, 2024
Comment on lines
613
to
614
| @pytest.mark.parametrize("format_version", [1, 2]) | ||
| @pytest.mark.parametrize('catalog', [pytest.lazy_fixture('session_catalog_hive'), pytest.lazy_fixture('session_catalog')]) |
Contributor
There was a problem hiding this comment.
We're mixing double and single quotes 😱 Shouldn't Ruff fix this?
Contributor
Author
There was a problem hiding this comment.
Our current setting is
[format]
quote-style = "preserve"which leave quotes unchanged.
I changed it to "double" and found that 39 files need to be re-formatted. I've created a separete PR to give it a try: #781
I will re-visit this issue tomorrow if the test fails :)
Contributor
There was a problem hiding this comment.
Now #781 is in, we need to rebase every PR anyway :D
# Conflicts: # pyiceberg/catalog/hive.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #498