Skip to content

Conversation

@himadripal
Copy link
Contributor

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @himadripal. Can you fix the conflicts? Thanks!

@himadripal
Copy link
Contributor Author

@Fokko Thank you for the approval. Fixed the conflict, can you please let the build checks run?

@Fokko
Copy link
Contributor

Fokko commented Feb 29, 2024

The easiest way is to fix this locally using make install && make lint

@himadripal
Copy link
Contributor Author

The easiest way is to fix this locally using make install && make lint

@Fokko Thank you for this tip.

@himadripal
Copy link
Contributor Author

himadripal commented Mar 1, 2024

locally all passed

(venv)  % poetry run pre-commit run --all-files
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check docstring is first.................................................Passed
debug statements (python)................................................Passed
check yaml...............................................................Passed
check python ast.........................................................Passed
ruff.....................................................................Passed
ruff-format..............................................................Passed
mypy.....................................................................Passed
pycln....................................................................Passed
mdformat.................................................................Passed
pydocstyle...............................................................Passed
flynt....................................................................Passed

@Fokko Can you rerun the build check please?

@himadripal himadripal force-pushed the make_scope_configurable branch from adfdea2 to e508a9f Compare March 1, 2024 19:14
added scope as configurable option, defaults to `CATALOG_SCOPE`

resolve conflicts.

change to constant

style fix
@himadripal himadripal force-pushed the make_scope_configurable branch from 01f6541 to f9635a6 Compare March 1, 2024 23:32
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you also create a PR to update the documentation:

| credential | t-1234:secret | Credential to use for OAuth2 credential flow when initializing the catalog |

Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks @himadripal for working on it.

@Fokko Fokko merged commit 0e1fe8a into apache:main Mar 5, 2024
@Fokko
Copy link
Contributor

Fokko commented Mar 5, 2024

Thanks for working on this @himadripal and for the review @flyrain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants