Fix environment variable parsing #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash
export PYICEBERG_CATALOG__SOMETHING__S3__REGION=eu-north-1
```
Before:
```python
>>> from pyiceberg.catalog import load_catalog
>>> load_catalog('something').properties
{'s3': {'region': 'eu-north-1'}, ...}
```
After:
```python
>>> from pyiceberg.catalog import load_catalog
>>> load_catalog('something').properties
{'s3.region': 'eu-north-1', ...}
```
Which correspondents with the key `s3.region` that we use.
Co-authored-by: Hussein Awala <[email protected]>
hussein-awala
approved these changes
Feb 13, 2024
amogh-jahagirdar
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on Slack: https://apache-iceberg.slack.com/archives/C029EE6HQ5D/p1707633685716559
export PYICEBERG_CATALOG__SOMETHING__S3__REGION=eu-north-1Before:
After:
Which correspondents with the key
s3.regionthat we use. Now the example makes sense: