Skip to content

Conversation

@kevinjqliu
Copy link
Contributor

Rationale for this change

Follow up to #2601
clean up .egg-info/ and setup.cfg from sdist

Are these changes tested?

Yes

Check the new sdist

rm -rf dist build pyiceberg.egg-info
uv build --sdist
tar -tzf dist/pyiceberg-*.tar.gz | grep -E "(build/|setup.cfg|\.egg-info)"

Diffed too

diff -qr ./dist/pyiceberg-0.10.0 ~/Downloads/nightly/sdist/ | sort

differ
    Files ./dist/pyiceberg-0.10.0/Makefile and /Users/kevinliu/Downloads/nightly/sdist/Makefile differ
    Files ./dist/pyiceberg-0.10.0/PKG-INFO and /Users/kevinliu/Downloads/nightly/sdist/PKG-INFO differ
    Files ./dist/pyiceberg-0.10.0/dev/.rat-excludes and /Users/kevinliu/Downloads/nightly/sdist/dev/.rat-excludes differ
    Files ./dist/pyiceberg-0.10.0/pyproject.toml and /Users/kevinliu/Downloads/nightly/sdist/pyproject.toml differ
new
    Only in ./dist/pyiceberg-0.10.0/tests: .DS_Store
    Only in ./dist/pyiceberg-0.10.0: MANIFEST.in
    Only in ./dist/pyiceberg-0.10.0: setup.py
removed
    Only in /Users/kevinliu/Downloads/nightly/sdist: build-module.py
    Only in /Users/kevinliu/Downloads/nightly/sdist: poetry.lock

In sdist, ran RAT check and tests

make check-license
make test-coverage

Are there any user-facing changes?

No

@kevinjqliu kevinjqliu requested a review from Fokko November 11, 2025 14:11
@kevinjqliu
Copy link
Contributor Author

cc @geruh

@kevinjqliu kevinjqliu merged commit c807124 into apache:main Nov 11, 2025
8 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/cleanup-sdist branch November 11, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants