feat: add support for setting and removing table properties on console #2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Jun 30, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This looks great @blinkseb 🙌
Maybe we can also add this to the docs: https://py.iceberg.apache.org/cli/
blinkseb
force-pushed
the
feat-set-table-properties-cli
branch
from
f16a8e4 to
27fae66
Compare
Contributor
Author
|
Thanks Fokko! I've updated the PR to use the context manager, and I added a new paragraph on the CLI doc to showcase the properties command. |
kevinjqliu
approved these changes
Jul 6, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
I also ran make docs-serve locally
Contributor
amitgilad3
pushed a commit
to amitgilad3/iceberg-python
that referenced
this pull request
Jul 7, 2025
apache#2153) <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Hello! Setting or removing table properties on console currently raise a `Writing is WIP` error. This PR adds the code to set and remove table properties. # Are these changes tested? Yes # Are there any user-facing changes? Yes, setting and removing table properties on console now works. <!-- In the case of user-facing changes, please add the changelog label. -->
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
apache#2153) <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Hello! Setting or removing table properties on console currently raise a `Writing is WIP` error. This PR adds the code to set and remove table properties. # Are these changes tested? Yes # Are there any user-facing changes? Yes, setting and removing table properties on console now works. <!-- In the case of user-facing changes, please add the changelog label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Hello!
Setting or removing table properties on console currently raise a
Writing is WIPerror. This PR adds the code to set and remove table properties.Are these changes tested?
Yes
Are there any user-facing changes?
Yes, setting and removing table properties on console now works.