feat(docs): example of multiple catalogs defined in .pyiceberg.yaml #194
Conversation
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
LGTM! Thanks @jayceslesar. Just a quick, non-blocking comment from my side
mkdocs/docs/api.md
Outdated
| uri: https://rest-server:8181/ | ||
| warehouse: my-warehouse | ||
| ``` | ||
| and loaded in python by calling `load_catalog`. See below for an example. |
There was a problem hiding this comment.
I think the example primarily illustrates how to load a catalog that is not defined in .pyiceberg.yaml. For catalogs that are defined in the yaml file, we might say
and loaded in python by calling `load_catalog(name="hive")` and `load_catalog(name="rest")`
Does this sound right to you?
There was a problem hiding this comment.
Yeah I think that is more explicit -- will add
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks @jayceslesar for fixing this! This was super obvious for me, but that's mostly because I wrote the code initially, thanks for adding this example 🙌
Thanks @HonahX for the prompt review!
|
@jayceslesar The Markdown linter has an improvement, can you run |
|
@Fokko my org has a manual job that can be run as part of a PR/MR that can run the lint and commit the changes? Is it worth looking at adding something similar? Or stick with the pre-commit? (which I just need to get used to haha) |
Ha, I'm aware of those systems, and I like them! I haven't looked into that much, but this would require committing on someone's behalf? |
3 participants
Spawned from #156