Add ResidualVisitor to compute residuals #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-op add count in data scan and test in catalog sql
kevinjqliu
reviewed
Nov 28, 2024
Contributor
|
Question: Does it make sense to expose this as the |
Residual Evaluator with test
* added residual evaluator in plan files * tested counts with positional deletes * merged main
* added residual evaluator in plan files * tested counts with positional deletes * merged main * implemented batch reader in count * breaking integration test * fixed integration test * git pull main * revert * revert * revert test_partitioning_key.py * revert test_parser.py * added residual evaluator in visitor * deleted residual_evaluator.py * removed test count from test_sql.py * ignored lint type * fixed lint * working on plan_files * type ignored * make lint
Contributor
Author
|
Hi @Fokko @kevinjqliu @gli-chris-hao , I have implemented these suggestions with my best understanding.
It would be helpful to get fresh review |
Fokko
changed the title
Fokko
reviewed
Feb 6, 2025
Fokko
reviewed
Feb 6, 2025
Fokko
reviewed
Feb 6, 2025
Fokko
reviewed
Feb 6, 2025
Fokko
reviewed
Feb 6, 2025
Fokko
reviewed
Feb 6, 2025
Fokko
reviewed
Feb 6, 2025
Fokko
reviewed
Feb 6, 2025
Fokko
reviewed
Feb 6, 2025
* added residual evaluator in plan files * tested counts with positional deletes * merged main * implemented batch reader in count * breaking integration test * fixed integration test * git pull main * revert * revert * revert test_partitioning_key.py * revert test_parser.py * added residual evaluator in visitor * deleted residual_evaluator.py * removed test count from test_sql.py * ignored lint type * fixed lint * working on plan_files * type ignored * make lint * explicit delete files len is zero * residual eval only if manifest is true * default residual is always true * used projection schema * refactored residual in plan files * fixed lint issue with isnan * simplified count if else conditions * implemented refactoring comments on residual visitor
Fokko
added a commit
to Fokko/iceberg-python
that referenced
this pull request
Feb 10, 2025
Sometime I'm seeing this:
```
ImportError while loading conftest '/home/runner/work/iceberg-python/iceberg-python/tests/conftest.py'.
tests/conftest.py:52: in <module>
from pyiceberg.catalog import Catalog, load_catalog
pyiceberg/catalog/__init__.py:51: in <module>
from pyiceberg.serializers import ToOutputFile
pyiceberg/serializers.py:25: in <module>
from pyiceberg.table.metadata import TableMetadata, TableMetadataUtil
pyiceberg/table/__init__.py:65: in <module>
from pyiceberg.io.pyarrow import ArrowScan, schema_to_pyarrow
pyiceberg/io/pyarrow.py:141: in <module>
from pyiceberg.table.locations import load_location_provider
pyiceberg/table/locations.py:25: in <module>
from pyiceberg.table import TableProperties
E ImportError: cannot import name 'TableProperties' from partially initialized module 'pyiceberg.table' (most likely due to a circular import) (/home/runner/work/iceberg-python/iceberg-python/pyiceberg/table/__init__.py)
```
Also observed in: apache#1388
I prefer the imports at the top, but I think this is a small price
to pay to avoid having circular imports.
Merged
kevinjqliu
pushed a commit
that referenced
this pull request
Feb 10, 2025
Sometime I'm seeing this:
```
ImportError while loading conftest '/home/runner/work/iceberg-python/iceberg-python/tests/conftest.py'.
tests/conftest.py:52: in <module>
from pyiceberg.catalog import Catalog, load_catalog
pyiceberg/catalog/__init__.py:51: in <module>
from pyiceberg.serializers import ToOutputFile
pyiceberg/serializers.py:25: in <module>
from pyiceberg.table.metadata import TableMetadata, TableMetadataUtil
pyiceberg/table/__init__.py:65: in <module>
from pyiceberg.io.pyarrow import ArrowScan, schema_to_pyarrow
pyiceberg/io/pyarrow.py:141: in <module>
from pyiceberg.table.locations import load_location_provider
pyiceberg/table/locations.py:25: in <module>
from pyiceberg.table import TableProperties
E ImportError: cannot import name 'TableProperties' from partially initialized module 'pyiceberg.table' (most likely due to a circular import) (/home/runner/work/iceberg-python/iceberg-python/pyiceberg/table/__init__.py)
```
Also observed in: #1388
I prefer the imports at the top, but I think this is a small price to
pay to avoid having circular imports.
Fokko
reviewed
Feb 11, 2025
Fokko
reviewed
Feb 11, 2025
Fokko
approved these changes
Feb 11, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
def test_fokko(session_catalog):
import pyarrow.parquet as pq
df = pq.read_table("/Users/fokko.driesprong/Downloads/yellow_tripdata_2024-01.parquet")
session_catalog.drop_table("default.taxis")
tbl = session_catalog.create_table("default.taxis", schema=df.schema)
with tbl.update_spec() as spec:
spec.add_field("tpep_pickup_datetime", DayTransform())
tbl.append(df)
# tbl = session_catalog.load_table("default.taxis")
pred = LessThan("tpep_pickup_datetime", datetime.datetime(2024, 1, 3, 12, 0, 0))
cnt = tbl.scan(row_filter=pred).count()
assert cnt == len(df.filter(expression_to_pyarrow(pred.bind(tbl.schema()))))Works very well:
Fokko
reviewed
Feb 11, 2025
Contributor
|
Thanks @tusharchou for working on this 🚀 |
This was referenced Feb 11, 2025
Merged
kevinjqliu
pushed a commit
that referenced
this pull request
Feb 11, 2025
|
🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue: Count rows as a metadata-only operation #1223