fix: remove old, incorrect docstring #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sungwy couldn't find any |
Collaborator
|
Hi @dataders thank you very much for identifying this issue and putting up this PR! For future information, the Contributing guidelines can be found here: https://py.iceberg.apache.org/contributing/ For the purpose of this Issue, I think this PR looks great 👍 I'll approve it once the CI runs successfully. |
sungwy
approved these changes
Sep 12, 2024
Collaborator
|
Thanks again for your contribution! @dataders |
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1163
remove this line. no additions necessary as other
Catalogmethod's don't have additional context in the docstring beyond docmenting the signature