mod_session_dbd: set_cookie_name: ensure correct format #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covener
reviewed
Jan 1, 2025
modules/session/mod_session_dbd.c
Outdated
| @@ -571,6 +571,9 @@ static const char *set_cookie_name(cmd_parms * cmd, void *config, const char *ar | |||
| char *line = apr_pstrdup(cmd->pool, args); | |||
| session_dbd_dir_conf *conf = (session_dbd_dir_conf *) config; | |||
| char *cookie = apr_strtok(line, " \t", &last); | |||
| if(!cookie) { | |||
| return "Invalid directive, skipping"; | |||
There was a problem hiding this comment.
The string has "skipping" but won't this result in a startup error? Maybe "SessionDBDCookieName requires at least one argument"?
covener
reviewed
Jan 1, 2025
modules/session/mod_session_dbd.c
Outdated
| @@ -571,6 +571,9 @@ static const char *set_cookie_name(cmd_parms * cmd, void *config, const char *ar | |||
| char *line = apr_pstrdup(cmd->pool, args); | |||
| session_dbd_dir_conf *conf = (session_dbd_dir_conf *) config; | |||
| char *cookie = apr_strtok(line, " \t", &last); | |||
| if(!cookie) { | |||
There was a problem hiding this comment.
nit. httpd style has a space between if and (
If args is an empty string, apr_strtok will return NULL and *last will never get set which results in a SIGSEGV in apr_isspace check
thomasmey
force-pushed
the
bugfix/ap_config_fuzzing1
branch
from
99a37fb to
66ffcfa
Compare
covener
added a commit
to covener/httpd
that referenced
this pull request
Jan 6, 2025
If args is an empty string, apr_strtok will return NULL and *last will never get set which results in a SIGSEGV in apr_isspace check Submitted by: Thomas Meyer <[email protected]> Github: closes apache#503 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1922931 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 75facde)
asfgit
pushed a commit
that referenced
this pull request
Jun 10, 2025
If args is an empty string, apr_strtok will return NULL and *last will never get set which results in a SIGSEGV in apr_isspace check Submitted by: Thomas Meyer <[email protected]> Github: closes #503 Follow-up to r1922931. In set_cookie_name() and set_cookie_name2(), now that the empty 'name' argument is explicitly handled, the error message in check_string() can be simplified because the cookie name can't be empty anymore when this function is called. Add a change entry to give credits to the author. Merges r1922931, r1926188, r1926189 trunk Submitted by: covener, jailletc36, jailletc36 Reviewed by: jailletc36, rpluem, ylavic git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1926325 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If args is an empty string, apr_strtok will return NULL and *last will never get set which results in a SIGSEGV in apr_isspace check