HIVE-23870: Optimise multiple text conversions in HiveCharWritable/WritableHiveCharObjectInspector #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectInspector.getPrimitiveJavaObject / HiveCharWritable
|
So, this caches the charLength ? That is the fix here? |
|
This is an interesting observation. However, maybe this should be contributed to Hadoop project directly. |
…ectInspector.getPrimitiveJavaObject / HiveCharWritable
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
ashutoshc
approved these changes
Jul 23, 2020
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed runtime dropping from "7600s --> 4800s" in internal cluster, when running a job which creates materialized view on warehouse/inventory/date_dim (where warehouse had char/varchar).