Skip to content

HBASE-23238: Remove 'static'ness of cell counter in LimitKVsReturnFil… #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2019
Merged

HBASE-23238: Remove 'static'ness of cell counter in LimitKVsReturnFil… #963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannersFromClientSide.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,7 @@ public void testScannerWithPartialResults() throws Exception {
Result result;
int expectedKvNumber = 6;
int returnedKvNumber = 0;
while((result = rs.next()) != null){
while((result = rs.next()) != null) {
returnedKvNumber += result.listCells().size();
}
rs.close();
Expand All @@ -873,24 +873,24 @@ public void testScannerWithPartialResults() throws Exception {

public static class LimitKVsReturnFilter extends FilterBase {

private static int total = 0;
private int cellCount = 0;

@Override
public ReturnCode filterCell(Cell v) throws IOException {
if(total>=6) {
total++;
if (cellCount >= 6) {
cellCount++;
return ReturnCode.SKIP;
}
total++;
cellCount++;
return ReturnCode.INCLUDE;
}

@Override
public boolean filterAllRemaining() throws IOException {
if(total<7) {
if (cellCount < 7) {
return false;
}
total++;
cellCount++;
return true;
}

Expand All @@ -900,9 +900,8 @@ public String toString() {
}

public static LimitKVsReturnFilter parseFrom(final byte [] pbBytes)
throws DeserializationException {
throws DeserializationException {
return new LimitKVsReturnFilter();
}
}

}