Skip to content

HBASE-29682: Roll HMaster WAL in response to FlushMasterStoreRequest #7407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −5
Open

HBASE-29682: Roll HMaster WAL in response to FlushMasterStoreRequest #7407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4479,6 +4479,13 @@ public void flushMasterStore() throws IOException {
}
}
masterRegion.flush(true);

try {
masterRegion.requestRollAll();
masterRegion.waitUntilWalRollFinished();
} catch (Exception e) {
throw new IOException("Error rolling HMaster WAL", e);
}
if (this.cpHost != null) {
try {
cpHost.postMasterStoreFlush();
Expand Down
5 changes: 0 additions & 5 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

import static org.apache.hadoop.hbase.HConstants.HREGION_LOGDIR_NAME;

import com.google.errorprone.annotations.RestrictedApi;
import java.io.IOException;
import java.util.List;
import java.util.Optional;
Expand Down Expand Up @@ -248,14 +247,10 @@ public FlushResult flush(boolean force) throws IOException {
}
}

@RestrictedApi(explanation = "Should only be called in tests", link = "",
allowedOnPath = ".*/src/test/.*")
public void requestRollAll() {
walRoller.requestRollAll();
}

@RestrictedApi(explanation = "Should only be called in tests", link = "",
allowedOnPath = ".*/src/test/.*")
public void waitUntilWalRollFinished() throws InterruptedException {
walRoller.waitUntilWalRollFinished();
}
Expand Down