HBASE-29643: Admin API to trigger for System Key rotation #7394

haridsv · 2025-10-16T16:03:48Z

Adds a new rotateSTK key management API and a corresponding rotate_stk shell commannd.
HBASE-29643

Apache-HBase · 2025-10-17T10:30:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 8s		HBASE-29368-key-management-feature passed
+1 💚	compile	8m 29s		HBASE-29368-key-management-feature passed
+1 💚	checkstyle	1m 9s		HBASE-29368-key-management-feature passed
-1 ❌	spotbugs	1m 34s	/branch-spotbugs-hbase-server-warnings.html	hbase-server in HBASE-29368-key-management-feature has 2 extant spotbugs warnings.
-1 ❌	spotbugs	7m 27s	/branch-spotbugs-root-warnings.html	root in HBASE-29368-key-management-feature has 2 extant spotbugs warnings.
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 6s		the patch passed
+1 💚	compile	8m 28s		the patch passed
+1 💚	cc	8m 28s		the patch passed
+1 💚	javac	8m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 13s	/results-checkstyle-root.txt	root: The patch generated 22 new + 14 unchanged - 0 fixed = 36 total (was 14)
-0 ⚠️	rubocop	0m 17s	/results-rubocop.txt	The patch generated 9 new + 42 unchanged - 176 fixed = 51 total (was 218)
+1 💚	spotbugs	13m 17s		the patch passed
+1 💚	hadoopcheck	11m 54s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	hbaseprotoc	4m 48s		the patch passed
-1 ❌	spotless	0m 39s		patch has 26 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 53s		The patch does not generate ASF License warnings.
		80m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7394
JIRA Issue	HBASE-29643
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc rubocop yamllint
uname	Linux 5e94bc433303 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29368-key-management-feature / `c3ac599`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	190 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-17T14:52:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 33s		HBASE-29368-key-management-feature passed
+1 💚	compile	2m 14s		HBASE-29368-key-management-feature passed
+1 💚	javadoc	3m 28s		HBASE-29368-key-management-feature passed
+1 💚	shadedjars	6m 25s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 8s		the patch passed
+1 💚	compile	2m 14s		the patch passed
+1 💚	javac	2m 14s		the patch passed
+1 💚	javadoc	3m 25s		the patch passed
+1 💚	shadedjars	6m 22s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	302m 13s	/patch-unit-root.txt	root in the patch failed.
		342m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7394
JIRA Issue	HBASE-29643
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 9d80fe9658c5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29368-key-management-feature / `c3ac599`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/3/testReport/
Max. process+thread count	6320 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-21T12:58:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 17s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for branch
+1 💚	mvninstall	6m 4s		HBASE-29368-key-management-feature passed
+1 💚	compile	4m 2s		HBASE-29368-key-management-feature passed
+1 💚	javadoc	5m 58s		HBASE-29368-key-management-feature passed
+1 💚	shadedjars	9m 23s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 54s		the patch passed
+1 💚	compile	4m 20s		the patch passed
+1 💚	javac	4m 20s		the patch passed
+1 💚	javadoc	5m 57s		the patch passed
+1 💚	shadedjars	8m 54s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	11m 30s	/patch-unit-root.txt	root in the patch failed.
		64m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7394
JIRA Issue	HBASE-29643
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 8244fe7e7b91 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29368-key-management-feature / `dd56486`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/4/testReport/
Max. process+thread count	616 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-21T13:45:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 12s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	buf	0m 1s		buf was not available.
+0 🆗	buf	0m 1s		buf was not available.
+0 🆗	yamllint	0m 1s		yamllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	5m 6s		HBASE-29368-key-management-feature passed
+1 💚	compile	13m 42s		HBASE-29368-key-management-feature passed
+1 💚	checkstyle	1m 29s		HBASE-29368-key-management-feature passed
-1 ❌	spotbugs	12m 11s	/branch-spotbugs-root-warnings.html	root in HBASE-29368-key-management-feature has 2 extant spotbugs warnings.
-1 ❌	spotbugs	2m 12s	/branch-spotbugs-hbase-server-warnings.html	hbase-server in HBASE-29368-key-management-feature has 2 extant spotbugs warnings.
+1 💚	spotless	1m 6s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 40s		the patch passed
+1 💚	compile	13m 41s		the patch passed
+1 💚	cc	13m 41s		the patch passed
+1 💚	javac	13m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 23s	/results-checkstyle-root.txt	root: The patch generated 22 new + 15 unchanged - 0 fixed = 37 total (was 15)
-0 ⚠️	rubocop	0m 20s	/results-rubocop.txt	The patch generated 9 new + 42 unchanged - 176 fixed = 51 total (was 218)
+1 💚	spotbugs	19m 41s		the patch passed
+1 💚	hadoopcheck	14m 6s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	hbaseprotoc	6m 2s		the patch passed
-1 ❌	spotless	0m 26s		patch has 39 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	1m 0s		The patch does not generate ASF License warnings.
		111m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7394
JIRA Issue	HBASE-29643
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc rubocop yamllint
uname	Linux 8ae7f47c3534 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29368-key-management-feature / `dd56486`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/4/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	161 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-21T23:03:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 12s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 43s		HBASE-29368-key-management-feature passed
+1 💚	compile	2m 59s		HBASE-29368-key-management-feature passed
+1 💚	javadoc	4m 29s		HBASE-29368-key-management-feature passed
+1 💚	shadedjars	6m 44s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 10s		the patch passed
+1 💚	compile	3m 0s		the patch passed
+1 💚	javac	3m 0s		the patch passed
+1 💚	javadoc	4m 26s		the patch passed
+1 💚	shadedjars	6m 40s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	9m 41s	/patch-unit-root.txt	root in the patch failed.
		49m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7394
JIRA Issue	HBASE-29643
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux bfd122f6cf0d 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29368-key-management-feature / `dd56486`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/5/testReport/
Max. process+thread count	598 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-22T00:18:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 13s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	5m 10s		HBASE-29368-key-management-feature passed
+1 💚	compile	15m 5s		HBASE-29368-key-management-feature passed
+1 💚	checkstyle	1m 58s		HBASE-29368-key-management-feature passed
-1 ❌	spotbugs	2m 34s	/branch-spotbugs-hbase-server-warnings.html	hbase-server in HBASE-29368-key-management-feature has 2 extant spotbugs warnings.
-1 ❌	spotbugs	13m 33s	/branch-spotbugs-root-warnings.html	root in HBASE-29368-key-management-feature has 2 extant spotbugs warnings.
+1 💚	spotless	1m 23s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 28s		the patch passed
+1 💚	compile	14m 45s		the patch passed
+1 💚	cc	14m 45s		the patch passed
+1 💚	javac	14m 45s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 33s	/results-checkstyle-root.txt	root: The patch generated 22 new + 15 unchanged - 0 fixed = 37 total (was 15)
-0 ⚠️	rubocop	0m 23s	/results-rubocop.txt	The patch generated 9 new + 42 unchanged - 176 fixed = 51 total (was 218)
+1 💚	spotbugs	20m 25s		the patch passed
+1 💚	hadoopcheck	14m 58s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	hbaseprotoc	7m 44s		the patch passed
-1 ❌	spotless	0m 29s		patch has 39 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	1m 31s		The patch does not generate ASF License warnings.
		124m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7394
JIRA Issue	HBASE-29643
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc rubocop yamllint
uname	Linux 3c1d01ae9400 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29368-key-management-feature / `dd56486`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/5/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	163 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…s:apply

…e for future APIs

Apache-HBase · 2025-10-26T16:30:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 15s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	5m 31s		HBASE-29368-key-management-feature passed
+1 💚	compile	14m 47s		HBASE-29368-key-management-feature passed
+1 💚	checkstyle	1m 34s		HBASE-29368-key-management-feature passed
-1 ❌	spotbugs	13m 5s	/branch-spotbugs-root-warnings.html	root in HBASE-29368-key-management-feature has 2 extant spotbugs warnings.
-1 ❌	spotbugs	2m 23s	/branch-spotbugs-hbase-server-warnings.html	hbase-server in HBASE-29368-key-management-feature has 2 extant spotbugs warnings.
+1 💚	spotless	1m 11s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 5s		the patch passed
+1 💚	compile	14m 44s		the patch passed
+1 💚	cc	14m 44s		the patch passed
+1 💚	javac	14m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 35s	/results-checkstyle-root.txt	root: The patch generated 21 new + 21 unchanged - 0 fixed = 42 total (was 21)
-0 ⚠️	rubocop	0m 23s	/results-rubocop.txt	The patch generated 9 new + 42 unchanged - 176 fixed = 51 total (was 218)
+1 💚	spotbugs	24m 55s		the patch passed
+1 💚	hadoopcheck	16m 40s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	hbaseprotoc	7m 42s		the patch passed
+1 💚	spotless	1m 16s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	1m 38s		The patch does not generate ASF License warnings.
		131m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7394
JIRA Issue	HBASE-29643
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc rubocop yamllint
uname	Linux 435530c4a272 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29368-key-management-feature / `f732e29`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	162 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/9/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-26T16:56:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 15s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	5m 40s		HBASE-29368-key-management-feature passed
+1 💚	compile	3m 41s		HBASE-29368-key-management-feature passed
+1 💚	javadoc	6m 29s		HBASE-29368-key-management-feature passed
+1 💚	shadedjars	9m 29s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 36s		the patch passed
+1 💚	compile	3m 57s		the patch passed
+1 💚	javac	3m 57s		the patch passed
+1 💚	javadoc	6m 38s		the patch passed
+1 💚	shadedjars	9m 40s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	39m 34s	/patch-unit-root.txt	root in the patch failed.
		94m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7394
JIRA Issue	HBASE-29643
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 3f219f94378d 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29368-key-management-feature / `f732e29`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/9/testReport/
Max. process+thread count	972 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/9/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-26T18:34:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 1s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	5m 30s		HBASE-29368-key-management-feature passed
+1 💚	compile	3m 11s		HBASE-29368-key-management-feature passed
+1 💚	javadoc	5m 40s		HBASE-29368-key-management-feature passed
+1 💚	shadedjars	7m 18s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 28s		the patch passed
+1 💚	compile	3m 5s		the patch passed
+1 💚	javac	3m 5s		the patch passed
+1 💚	javadoc	5m 31s		the patch passed
+1 💚	shadedjars	7m 14s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	48m 28s	/patch-unit-root.txt	root in the patch failed.
		96m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/10/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7394
JIRA Issue	HBASE-29643
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux a90412972928 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29368-key-management-feature / `f732e29`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/10/testReport/
Max. process+thread count	1152 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/10/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-26T19:12:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 14s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	buf	0m 1s		buf was not available.
+0 🆗	buf	0m 1s		buf was not available.
+0 🆗	yamllint	0m 1s		yamllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ HBASE-29368-key-management-feature Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	5m 7s		HBASE-29368-key-management-feature passed
+1 💚	compile	15m 20s		HBASE-29368-key-management-feature passed
+1 💚	checkstyle	1m 49s		HBASE-29368-key-management-feature passed
-1 ❌	spotbugs	2m 32s	/branch-spotbugs-hbase-server-warnings.html	hbase-server in HBASE-29368-key-management-feature has 2 extant spotbugs warnings.
-1 ❌	spotbugs	13m 44s	/branch-spotbugs-root-warnings.html	root in HBASE-29368-key-management-feature has 2 extant spotbugs warnings.
+1 💚	spotless	1m 20s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 22s		the patch passed
+1 💚	compile	16m 1s		the patch passed
+1 💚	cc	16m 1s		the patch passed
+1 💚	javac	16m 1s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 49s	/results-checkstyle-root.txt	root: The patch generated 21 new + 21 unchanged - 0 fixed = 42 total (was 21)
-0 ⚠️	rubocop	0m 27s	/results-rubocop.txt	The patch generated 9 new + 42 unchanged - 176 fixed = 51 total (was 218)
+1 💚	spotbugs	25m 3s		the patch passed
+1 💚	hadoopcheck	15m 42s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	hbaseprotoc	7m 36s		the patch passed
+1 💚	spotless	1m 8s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	1m 23s		The patch does not generate ASF License warnings.
		134m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7394
JIRA Issue	HBASE-29643
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc rubocop yamllint
uname	Linux cfd110f3a496 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29368-key-management-feature / `f732e29`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	163 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7394/10/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

haridsv added 17 commits October 15, 2025 11:53

First cut from Cursor for @HBASE-29643, unteste

00dd74c

Review feedback 1, still untested

220b65e

Review feedback 2, still untested

8d93ce1

Removed stale imports causing compilation errors

dad6864

Test fixes

46bbc95

Review feedback 3

8110fa9

Use the right SystemKeyManager instance and make it easier to test

6776634

More test coverage

9e7c5d8

Ran spotless:apply

68249ef

More test coverage

76c9704

More test coverage

e4f72c5

Renamed API

3660e8b

HBase shell command, untested

097d5c1

Extended shell test coverage

216be42

Update STK cache in HMaster and some test improvements

324561d

Remove code duplication

a316b4a

More test coverage

1b3247f

This comment has been minimized.

Sign in to view

Fix test failures

3a4e673

This comment has been minimized.

Sign in to view

Addressed majority of the Rubocop issues

20ad049

haridsv force-pushed the system-key-rotation branch from ea4bfc7 to 1708170 Compare October 17, 2025 06:45

Checstyle errors

c3ac599

haridsv force-pushed the system-key-rotation branch from 1708170 to c3ac599 Compare October 17, 2025 06:47

This comment has been minimized.

Sign in to view

haridsv added 2 commits October 21, 2025 11:30

Use existing async pattern for rotateSTK

2be6e8b

Reuse EmptyMsg in more places

1b2ccaa

Use direct server list

dd56486

haridsv added 5 commits October 22, 2025 11:58

Updated the return type of enable RPC for consistency and ran spotles…

968ab1f

…s:apply

Fix TestInterfaceAlign

5e36df1

Ran spotless:apply

49da3fb

Corrected the key custodian API param type to set the right precedenc…

bd86690

…e for future APIs

Another name cleanup, hopefully the last one

f732e29

virajjasani approved these changes Oct 27, 2025

View reviewed changes

virajjasani merged commit 020adaa into apache:HBASE-29368-key-management-feature Oct 27, 2025
1 check failed

Uh oh!

HBASE-29643: Admin API to trigger for System Key rotation #7394

HBASE-29643: Admin API to trigger for System Key rotation #7394

Uh oh!

Conversation

haridsv commented Oct 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Oct 17, 2025

Uh oh!

Apache-HBase commented Oct 17, 2025

Uh oh!

Apache-HBase commented Oct 21, 2025

Uh oh!

Apache-HBase commented Oct 21, 2025

Uh oh!

Apache-HBase commented Oct 21, 2025

Uh oh!

Apache-HBase commented Oct 22, 2025

Uh oh!

Apache-HBase commented Oct 26, 2025

Uh oh!

Apache-HBase commented Oct 26, 2025

Uh oh!

Apache-HBase commented Oct 26, 2025

Uh oh!

Apache-HBase commented Oct 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants