Skip to content

Backport "HBASE-29663 TimeBasedLimiters should support dynamic configuration re…" to branch-2 #7393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: HBASE-29684 Replication peer config is not honored in few cases
merged 1 commit into from
Oct 17, 2025
Merged

Backport "HBASE-29663 TimeBasedLimiters should support dynamic configuration re…" to branch-2 #7393

merged 1 commit into from
Oct 17, 2025
+99 −69

Conversation

@rmdmattingly
Copy link
Contributor

…fresh (#7387)

@rmdmattingly
HBASE-29663 TimeBasedLimiters should support dynamic configuration re…
a6edd64 
…fresh (#7387)

Co-authored-by: Ray Mattingly <[email protected]>
Signed-off-by: Charles Connell <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 50s branch-2 passed
+1 💚 compile 3m 22s branch-2 passed
+1 💚 checkstyle 0m 50s branch-2 passed
+1 💚 spotbugs 2m 27s branch-2 passed
+1 💚 spotless 0m 51s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 14s the patch passed
+1 💚 compile 3m 48s the patch passed
+1 💚 javac 3m 48s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 13s the patch passed
+1 💚 spotbugs 3m 7s the patch passed
+1 💚 hadoopcheck 19m 16s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
47m 23s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7393
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 1b42c77c2074 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / a6edd64
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 77 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 20s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 59s branch-2 passed
+1 💚 compile 1m 2s branch-2 passed
+1 💚 javadoc 0m 39s branch-2 passed
+1 💚 shadedjars 7m 37s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 6s the patch passed
+1 💚 compile 1m 1s the patch passed
+1 💚 javac 1m 1s the patch passed
+1 💚 javadoc 0m 35s the patch passed
+1 💚 shadedjars 7m 24s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 493m 55s /patch-unit-hbase-server.txt hbase-server in the patch failed.
528m 14s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #7393
Optional Tests javac javadoc unit compile shadedjars
uname Linux 17590e13078e 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / a6edd64
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/testReport/
Max. process+thread count 2213 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 3m 0s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 6m 9s branch-2 passed
+1 💚 compile 1m 59s branch-2 passed
+1 💚 javadoc 1m 5s branch-2 passed
+1 💚 shadedjars 10m 35s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 50s the patch passed
+1 💚 compile 1m 23s the patch passed
+1 💚 javac 1m 23s the patch passed
+1 💚 javadoc 0m 39s the patch passed
+1 💚 shadedjars 8m 42s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 540m 5s /patch-unit-hbase-server.txt hbase-server in the patch failed.
583m 12s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7393
Optional Tests javac javadoc unit compile shadedjars
uname Linux de26be106b29 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / a6edd64
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/testReport/
Max. process+thread count 2376 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 16s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 6m 11s branch-2 passed
+1 💚 compile 1m 18s branch-2 passed
+1 💚 javadoc 0m 43s branch-2 passed
+1 💚 shadedjars 10m 9s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 39s the patch passed
+1 💚 compile 1m 27s the patch passed
+1 💚 javac 1m 27s the patch passed
+1 💚 javadoc 0m 45s the patch passed
+1 💚 shadedjars 8m 55s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 543m 21s /patch-unit-hbase-server.txt hbase-server in the patch failed.
585m 30s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #7393
Optional Tests javac javadoc unit compile shadedjars
uname Linux e8a17865e3e7 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / a6edd64
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/testReport/
Max. process+thread count 2390 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7393/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@rmdmattingly rmdmattingly merged commit 69e7dcc into branch-2 Oct 17, 2025
1 check failed
@rmdmattingly rmdmattingly deleted the HBASE-29663-branch-2 branch October 17, 2025 13:01
rmdmattingly added a commit that referenced this pull request Oct 17, 2025
@rmdmattingly
HBASE-29663 TimeBasedLimiters should support dynamic configuration re…
d16471e 
…fresh (#7387) (#7393)

Signed-off-by: Charles Connell <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Co-authored-by: Ray Mattingly <[email protected]>
@rmdmattingly rmdmattingly mentioned this pull request Oct 17, 2025
Merged
rmdmattingly added a commit that referenced this pull request Oct 17, 2025
@rmdmattingly
HBASE-29663 TimeBasedLimiters should support dynamic configuration re…
26cbc3e 
…fresh (#7387) (#7393) (#7395)

Signed-off-by: Charles Connell <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Co-authored-by: Ray Mattingly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmdmattingly @Apache-HBase