HBASE-29596 Migrate Canary Status Jamon page back to JSP

[PDavid]

This is the last step of the Jamon to JSP migration: the Canary Status page.

Did the migration the same way as for the:

• Master Status page: HBASE-29223 Migrate Master Status Jamon page back to JSP #6875
• Region Status page: HBASE-29531 Migrate RegionServer Status Jamon page back to JSP #7371

Migrated the Jamon code to JSP as close as possible. Extracted some duplicated server link code to new java class: CanaryStatusUtil and added unit tests.

Changed the Canary Server Status page back to /canary.jsp. Made sure that /canary-status redirects to /canary.jsp.

Introduced a src/main/resources/hbase-webapps/common directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.

Made sure to compile Canary JSP files the same way as we do for Master and Region server JSP pages.

Removed the Jamon Maven dependencies and references to Jamon code.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s		master passed
+1 💚	compile	8m 18s		master passed
+1 💚	checkstyle	1m 8s		master passed
+1 💚	spotbugs	9m 15s		master passed
+0 🆗	refguide	2m 1s		branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 59s		the patch passed
+1 💚	compile	8m 18s		the patch passed
+1 💚	javac	8m 18s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 7s	/results-checkstyle-root.txt	root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	xmllint	0m 1s		No new issues.
+1 💚	spotbugs	9m 36s		the patch passed
+0 🆗	refguide	2m 10s		patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	12m 19s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 58s		The patch does not generate ASF License warnings.
		71m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7390/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7390
Optional Tests	dupname asflicense checkstyle javac codespell detsecrets xmllint spotless hadoopcheck compile spotbugs hbaseanti refguide
uname	Linux afa4b5052d6a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 123b814
Default Java	Eclipse Adoptium-17.0.11+9
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-7390/2/yetus-general-check/output/branch-site/book.html
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-7390/2/yetus-general-check/output/patch-site/book.html
Max. process+thread count	190 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-zookeeper hbase-resource-bundle hbase-server hbase-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7390/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[PDavid]

Testing

Tested this by starting HBase in standalone mode with mvn clean install -DskipTests && bin/start-hbase.sh.

Configured Canary tool info port in conf/hbase-site.xml:

...
  <property>
    <name>hbase.canary.info.port</name>
    <value>16019</value>
  </property>
...

Started the Canary tool in daemon mode (this provides the Canary Status page web UI) with ./bin/hbase canary -daemon -interval 5 -f false

Checked the Canary Status web UI page:

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s		master passed
+1 💚	compile	2m 15s		master passed
+1 💚	javadoc	3m 5s		master passed
+1 💚	shadedjars	6m 18s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 9s		the patch passed
+1 💚	compile	2m 17s		the patch passed
+1 💚	javac	2m 17s		the patch passed
+1 💚	javadoc	3m 3s		the patch passed
+1 💚	shadedjars	6m 16s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	273m 22s	/patch-unit-root.txt	root in the patch failed.
		312m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7390/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7390
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0254517e43f1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 123b814
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7390/2/testReport/
Max. process+thread count	3934 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-zookeeper hbase-resource-bundle hbase-server hbase-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7390/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[PDavid]

TestRSGroupsWithACL failed in the PR build. I think it is not related.