HBASE-29659 Replace reflow-default-webdeps to fix site build failure #7386
+118
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eflow-default-webdeps Reason: reflow-default-webdeps causes a Maven ERROR and Yetus build considers the site build to be broken. Turned off these features in the site skin which we don't need and would require to add more JavaScript: - highlight.js, - lightbox.js, - smooth scrolling. Improved code blocks style to look good without highlight.js. Also extracted MathJax.js and fontawesome (needed for RefGuide) versions to Maven properties.
|
Implemented this based on how reflow-default-webdeps pom.xml gathers these dependencies except the problematic hightlight.js: Tested this the following way: Built the site locally by executing the command which yetus runs, then server the site locally via HTTP server: The Maven build log does not contain The website is functional - no missing JS, CSS, webfont, no error on browser developer console - OK ✔️ 
RefGuide looks good - fontawesome icons and mathematical formulas are displayed - OK ✔️ 
|
ndimiduk
reviewed
Oct 14, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
instead of downloading it from a URL. We prefer maven resource as it can be cached locally.
PDavid
commented
Oct 15, 2025
Comment on lines
+33
to
+36
| background-color: #f5f5f5; | ||
| border-radius: 6px; | ||
| border: 1px solid rgba(0, 0, 0, 0.15); | ||
| padding: 10px; |
There was a problem hiding this comment.
Improved code blocks style to look good without highlight.js.
PDavid
changed the title
ndimiduk
approved these changes
Oct 15, 2025
|
🎊 +1 overall
This message was automatically generated. |
|
The PR build timed out. I'm merging this now to fix the RefGuide build on master. If we see any issues there we can still fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace reflow-default-webdeps with separate webjar dependencies because reflow-default-webdeps causes a Maven ERROR in the build log and Yetus build considers the site build to be broken.
Turned off these features in the site skin which we don't need and would require to add more JavaScript:
Improved code blocks style to look good without highlight.js.
Also extracted MathJax.js and fontawesome (needed for RefGuide) versions to Maven properties.