HBASE-29009 Depend on jaxws-rt instead jaxws-ri #6504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This removes 12 unneccessary JARs but adds duplicate versions in the assembly for two. I plan to deal with the duplicate dependencies in a separate JIRA. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Apache9
reviewed
Dec 8, 2024
pom.xml
Outdated
| <!-- | ||
| Note that the version of jackson-[annotations,core,databind] must be kept in sync with the | ||
| version of jackson-jaxrs-json-provider shipped in hbase-thirdparty. | ||
| version of jackson-jax/rs-json-provider shipped in hbase-thirdparty. |
Contributor
There was a problem hiding this comment.
Why this change? I think 'jackson-jaxrs-json-provider' is the name of the library?
Contributor
Author
There was a problem hiding this comment.
Thanks.
That's just a typo.
Reverted.
Contributor
Author
|
I'm holding this until we remove jax-ri from the assembly. After the removal, this will only apply to the test classpath (but simplifying that is also worth doing). |
NihalJain
approved these changes
Dec 9, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mnpoonia
approved these changes
Dec 10, 2024
stoty
added a commit
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Nihal Jain <[email protected]> Reviewed-by: Aman Poonia <[email protected]> (cherry picked from commit 260d9f2)
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
gvprathyusha6
pushed a commit
to gvprathyusha6/hbase
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Nihal Jain <[email protected]> Reviewed-by: Aman Poonia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.