HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #6434

NihalJain · 2024-11-04T07:38:46Z

Backports HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #6218 / HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #5607

…pache#6218) (apache#5607) - Also handle changes required for hadoop-2 assembly Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit b6394b1) (cherry picked from commit 2537690)

NihalJain · 2024-11-04T09:30:41Z

Verified following on branch-2.5

Built code and ran hbase-shell unit tests locally
Started hbase master in standalone, did basic shell sanity
Started hbase-rest in standalone, did basic rest sanity
Started hbase-thrift in standalone, ran thrift examples

Apache-HBase · 2024-11-06T22:22:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 47s		branch-2.5 passed
+1 💚	compile	5m 3s		branch-2.5 passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 42s		the patch passed
+1 💚	compile	5m 7s		the patch passed
+1 💚	javac	5m 7s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	xmllint	0m 2s		No new issues.
+1 💚	hadoopcheck	19m 15s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	1m 7s		The patch does not generate ASF License warnings.
		40m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6434
Optional Tests	dupname asflicense javac codespell detsecrets xmllint spotless hadoopcheck compile
uname	Linux 9d8afdb5c8a2 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `1e65255`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	74 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/console
versions	git=2.34.1 maven=3.9.8 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-07T02:34:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 4s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 59s		branch-2.5 passed
+1 💚	compile	3m 2s		branch-2.5 passed
+1 💚	javadoc	5m 12s		branch-2.5 passed
+1 💚	shadedjars	6m 49s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 45s		the patch passed
+1 💚	compile	2m 9s		the patch passed
+1 💚	javac	2m 9s		the patch passed
+1 💚	javadoc	4m 39s		the patch passed
+1 💚	shadedjars	6m 9s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	250m 37s	/patch-unit-root.txt	root in the patch failed.
		292m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6434
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dbd873d45752 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `1e65255`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/testReport/
Max. process+thread count	4716 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-07T03:16:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s		branch-2.5 passed
+1 💚	compile	2m 23s		branch-2.5 passed
+1 💚	javadoc	3m 42s		branch-2.5 passed
+1 💚	shadedjars	5m 58s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 31s		the patch passed
+1 💚	compile	2m 34s		the patch passed
+1 💚	javac	2m 34s		the patch passed
+1 💚	javadoc	3m 48s		the patch passed
+1 💚	shadedjars	6m 20s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	295m 50s		root in the patch passed.
		335m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6434
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 294ad3a38344 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `1e65255`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/testReport/
Max. process+thread count	7516 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-07T05:07:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 14s		branch-2.5 passed
+1 💚	compile	2m 9s		branch-2.5 passed
+1 💚	javadoc	3m 50s		branch-2.5 passed
+1 💚	shadedjars	5m 48s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 53s		the patch passed
+1 💚	compile	2m 13s		the patch passed
+1 💚	javac	2m 13s		the patch passed
+1 💚	javadoc	3m 52s		the patch passed
+1 💚	shadedjars	5m 31s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	407m 57s		root in the patch passed.
		446m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6434
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cbedecb14f43 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `1e65255`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/testReport/
Max. process+thread count	6630 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-server hbase-thrift hbase-rest hbase-shaded/hbase-shaded-mapreduce hbase-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6434/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-11-07T11:34:56Z

Failure are unrelated and do not fail consistently with this change!

NihalJain added the backport This PR is a back port of some issue or issues already committed to master label Nov 4, 2024

This comment has been minimized.

Sign in to view

NihalJain merged commit 4bb5f94 into apache:branch-2.5 Nov 7, 2024
1 check failed

HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #6434

HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper #6434

Uh oh!

Conversation

NihalJain commented Nov 4, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

NihalJain commented Nov 4, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 6, 2024

Uh oh!

Apache-HBase commented Nov 7, 2024

Uh oh!

Apache-HBase commented Nov 7, 2024

Uh oh!

Apache-HBase commented Nov 7, 2024

Uh oh!

NihalJain commented Nov 7, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants