-
Couldn't load subscription status.
- Fork 3.4k
HBASE-28942 Purge all netty 3 dependencies by default #6406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a rule to ban netty3 from transitive dependencies like in here: https://github.com/apache/hbase/blob/master/hbase-shaded/hbase-shaded-with-hadoop-check-invariants/pom.xml#L94
|
We have lots of enforcer rule in the root pom but unfortunately we still need to support compiling with hadoop 3.x so we can not add this rule... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite see how these changes match the title. Nett3 was a transitive dependency of one of these removed jars?
|
The jmemcahed daemon depends on netty, so here I used mockito to inject the memcached client, then we do not need to start the jmemcached daemon any more. Jmemcached is not active for more than 10 years... |
Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit a2d508a)
Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit a2d508a)
Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit a2d508a)
Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit a2d508a) (cherry picked from commit 286bd69)
Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit a2d508a) (cherry picked from commit 286bd69)
No description provided.