HBASE-28927 Fix spotbugs issues introduced by refactoring to hbase-di… #6384

NihalJain · 2024-10-22T09:38:11Z

…agnostics with HBASE-28432

NihalJain · 2024-10-22T09:39:51Z

hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java

    }

    @Override
    public int compareTo(RunResult o) {


Issue list for quick ref, lets see how many gets fixed with 1st commit:

Reason Tests

SpotBugs module:hbase-server

Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:[line 111]

SpotBugs module:root

Integral division result cast to double or float in org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions) At PerformanceEvaluation.java:double or float in org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions) At PerformanceEvaluation.java:[line 3154]

org.apache.hadoop.hbase.PerformanceEvaluation$RunResult defines compareTo(PerformanceEvaluation$RunResult) and uses Object.equals() At PerformanceEvaluation.java:Object.equals() At PerformanceEvaluation.java:[line 250]

Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:[line 111]

org.apache.hadoop.hbase.util.LoadTestTool.DEFAULT_NUM_REGIONS_PER_SERVER isn't final but should be At LoadTestTool.java:be At LoadTestTool.java:[line 167]

org.apache.hadoop.hbase.util.MultiThreadedAction.verifyResultAgainstDataGenerator(Result, boolean, boolean) concatenates strings using + in a loop At MultiThreadedAction.java:using + in a loop At MultiThreadedAction.java:[line 415]

Integral division result cast to double or float in org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run() At MultiThreadedAction.java:double or float in org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run() At MultiThreadedAction.java:[line 206]

org.apache.hadoop.hbase.util.MultiThreadedReader$HBaseReaderThread.createGet(long) concatenates strings using + in a loop At MultiThreadedReader.java:in a loop At MultiThreadedReader.java:[line 318]

Dead store to rowKey in org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get, boolean, long) At MultiThreadedReaderWithACL.java:org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get, boolean, long) At MultiThreadedReaderWithACL.java:[line 91]

Inconsistent synchronization of org.apache.hadoop.hbase.util.MultiThreadedUpdater.writer; locked 75% of time Unsynchronized access at MultiThreadedUpdater.java:75% of time Unsynchronized access at MultiThreadedUpdater.java:[line 80]

Unwritten field:MultiThreadedUpdaterWithACL.java:[line 94]

Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(String[]) At WALPerformanceEvaluation.java:is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(String[]) At WALPerformanceEvaluation.java:[line 244]

Format string should use %n rather than n in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.printUsageAndExit() At WALPerformanceEvaluation.java:rather than n in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.printUsageAndExit() At WALPerformanceEvaluation.java:[line 414]

Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation$WALPutBenchmark.run() At WALPerformanceEvaluation.java:is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation$WALPutBenchmark.run() At WALPerformanceEvaluation.java:[line 171]

hbase-server/src/main/java/org/apache/hadoop/hbase/util/LoadTestKVGenerator.java

…shCode()

NihalJain · 2024-10-22T14:31:55Z

All issues are fixed now. Could you please review? @stoty @ndimiduk

hbase-server/src/main/java/org/apache/hadoop/hbase/util/LoadTestKVGenerator.java

hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java

stoty

The random changes do not make sense, and are a potential perf hit.

stoty

+1 LGTM

NihalJain · 2024-10-22T15:42:37Z

+1 LGTM

Than you @stoty for the quick review :)
Will wait for all build stages to complete and then merge this.

Apache-HBase · 2024-10-22T15:59:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 54s		master passed
+1 💚	compile	3m 29s		master passed
+1 💚	checkstyle	0m 44s		master passed
-1 ❌	spotbugs	1m 31s	/branch-spotbugs-hbase-server-warnings.html	hbase-server in master has 1 extant spotbugs warnings.
-1 ❌	spotbugs	0m 26s	/branch-spotbugs-hbase-diagnostics-warnings.html	hbase-diagnostics in master has 12 extant spotbugs warnings.
-1 ❌	spotless	0m 43s		branch has 1 errors when running spotless:check, run spotless:apply to fix.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 51s		the patch passed
+1 💚	compile	3m 30s		the patch passed
-0 ⚠️	javac	0m 25s	/results-compile-javac-hbase-diagnostics.txt	hbase-diagnostics generated 1 new + 55 unchanged - 5 fixed = 56 total (was 60)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 36s		The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 8s		hbase-diagnostics: The patch generated 0 new + 43 unchanged - 1 fixed = 43 total (was 44)
+1 💚	spotbugs	1m 38s		hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	spotbugs	0m 34s		hbase-diagnostics generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12)
+1 💚	hadoopcheck	10m 43s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 16s		The patch does not generate ASF License warnings.
		38m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6384/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6384
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 32d9b25c584e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e8e2715`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6384/4/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server hbase-diagnostics U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6384/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-10-22T20:10:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 24s		master passed
+1 💚	compile	1m 20s		master passed
+1 💚	javadoc	0m 47s		master passed
+1 💚	shadedjars	6m 12s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 29s		the patch passed
+1 💚	compile	1m 23s		the patch passed
+1 💚	javac	1m 23s		the patch passed
+1 💚	javadoc	0m 47s		the patch passed
+1 💚	shadedjars	6m 10s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	254m 52s		hbase-server in the patch passed.
+1 💚	unit	5m 18s		hbase-diagnostics in the patch passed.
		289m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6384/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6384
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 2488de16aef9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e8e2715`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6384/4/testReport/
Max. process+thread count	4476 (vs. ulimit of 30000)
modules	C: hbase-server hbase-diagnostics U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6384/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…agnostics with HBASE-28432 (apache#6384) Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit f4aafaf)

…agnostics with HBASE-28432 (#6384) (#6387) Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit f4aafaf)

ndimiduk · 2024-10-30T09:54:32Z

Thanks @NihalJain

HBASE-28927 Fix spotbugs issues introduced by refactoring to hbase-di…

d0d18ff

…agnostics with HBASE-28432

NihalJain commented Oct 22, 2024

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/util/LoadTestKVGenerator.java Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Fix HE_EQUALS_USE_HASHCODE: Class defines equals() and uses Object.ha…

d11a68b

…shCode()

This comment has been minimized.

Sign in to view

Fix IS2_INCONSISTENT_SYNC: Inconsistent synchronization

3810220

This comment has been minimized.

Sign in to view

stoty reviewed Oct 22, 2024

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/util/LoadTestKVGenerator.java Outdated Show resolved Hide resolved

stoty reviewed Oct 22, 2024

View reviewed changes

hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java Show resolved Hide resolved

stoty requested changes Oct 22, 2024

View reviewed changes

Suppress DMI_RANDOM_USED_ONLY_ONCE

e8e2715

stoty approved these changes Oct 22, 2024

View reviewed changes

NihalJain merged commit f4aafaf into apache:master Oct 23, 2024
1 check failed

NihalJain mentioned this pull request Oct 23, 2024

HBASE-28927 Fix spotbugs issues introduced by refactoring to hbase-diagnostics with HBASE-28432 #6387

Merged

NihalJain added a commit that referenced this pull request Oct 24, 2024

HBASE-28927 Fix spotbugs issues introduced by refactoring to hbase-di…

acb6fae

…agnostics with HBASE-28432 (#6384) (#6387) Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit f4aafaf)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-28927 Fix spotbugs issues introduced by refactoring to hbase-di… #6384

HBASE-28927 Fix spotbugs issues introduced by refactoring to hbase-di… #6384

Uh oh!

NihalJain commented Oct 22, 2024

Uh oh!

NihalJain Oct 22, 2024 •

edited

Loading

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

NihalJain commented Oct 22, 2024

Uh oh!

Uh oh!

Uh oh!

stoty left a comment

Uh oh!

stoty left a comment

Uh oh!

NihalJain commented Oct 22, 2024 •

edited

Loading

Uh oh!

Apache-HBase commented Oct 22, 2024

Uh oh!

Apache-HBase commented Oct 22, 2024

Uh oh!

Uh oh!

ndimiduk commented Oct 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Reason	Tests
SpotBugs	module:hbase-server
	Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:[line 111]
SpotBugs	module:root
	Integral division result cast to double or float in org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions) At PerformanceEvaluation.java:double or float in org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions) At PerformanceEvaluation.java:[line 3154]
	org.apache.hadoop.hbase.PerformanceEvaluation$RunResult defines compareTo(PerformanceEvaluation$RunResult) and uses Object.equals() At PerformanceEvaluation.java:Object.equals() At PerformanceEvaluation.java:[line 250]
	Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:[line 111]
	org.apache.hadoop.hbase.util.LoadTestTool.DEFAULT_NUM_REGIONS_PER_SERVER isn't final but should be At LoadTestTool.java:be At LoadTestTool.java:[line 167]
	org.apache.hadoop.hbase.util.MultiThreadedAction.verifyResultAgainstDataGenerator(Result, boolean, boolean) concatenates strings using + in a loop At MultiThreadedAction.java:using + in a loop At MultiThreadedAction.java:[line 415]
	Integral division result cast to double or float in org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run() At MultiThreadedAction.java:double or float in org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run() At MultiThreadedAction.java:[line 206]
	org.apache.hadoop.hbase.util.MultiThreadedReader$HBaseReaderThread.createGet(long) concatenates strings using + in a loop At MultiThreadedReader.java:in a loop At MultiThreadedReader.java:[line 318]
	Dead store to rowKey in org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get, boolean, long) At MultiThreadedReaderWithACL.java:org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get, boolean, long) At MultiThreadedReaderWithACL.java:[line 91]
	Inconsistent synchronization of org.apache.hadoop.hbase.util.MultiThreadedUpdater.writer; locked 75% of time Unsynchronized access at MultiThreadedUpdater.java:75% of time Unsynchronized access at MultiThreadedUpdater.java:[line 80]
	Unwritten field:MultiThreadedUpdaterWithACL.java:[line 94]
	Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(String[]) At WALPerformanceEvaluation.java:is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(String[]) At WALPerformanceEvaluation.java:[line 244]
	Format string should use %n rather than n in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.printUsageAndExit() At WALPerformanceEvaluation.java:rather than n in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.printUsageAndExit() At WALPerformanceEvaluation.java:[line 414]
	Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation$WALPutBenchmark.run() At WALPerformanceEvaluation.java:is not thrown in org.apache.hadoop.hbase.wal.WALPerformanceEvaluation$WALPutBenchmark.run() At WALPerformanceEvaluation.java:[line 171]

HBASE-28927 Fix spotbugs issues introduced by refactoring to hbase-di… #6384

HBASE-28927 Fix spotbugs issues introduced by refactoring to hbase-di… #6384

Uh oh!

Conversation

NihalJain commented Oct 22, 2024

Uh oh!

NihalJain Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

NihalJain commented Oct 22, 2024

Uh oh!

Uh oh!

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

NihalJain commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Oct 22, 2024

Uh oh!

Apache-HBase commented Oct 22, 2024

Uh oh!

Uh oh!

ndimiduk commented Oct 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NihalJain Oct 22, 2024 •

edited

Loading

NihalJain commented Oct 22, 2024 •

edited

Loading