Skip to content

Conversation

@mnpoonia
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 49s master passed
+1 💚 compile 3m 13s master passed
+1 💚 checkstyle 0m 45s master passed
-1 ❌ spotbugs 1m 57s /branch-spotbugs-hbase-server-warnings.html hbase-server in master has 1 extant spotbugs warnings.
+1 💚 spotless 0m 53s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 28s the patch passed
+1 💚 compile 3m 32s the patch passed
+1 💚 javac 3m 32s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 40s the patch passed
+1 💚 spotbugs 1m 58s the patch passed
+1 💚 hadoopcheck 10m 46s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
39m 9s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6375/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6375
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 88fb3747b398 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 726b2d8
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6375/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 3s master passed
+1 💚 compile 0m 58s master passed
+1 💚 javadoc 0m 31s master passed
+1 💚 shadedjars 5m 11s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 56s the patch passed
+1 💚 compile 0m 59s the patch passed
+1 💚 javac 0m 59s the patch passed
+1 💚 javadoc 0m 30s the patch passed
+1 💚 shadedjars 5m 10s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 225m 35s hbase-server in the patch passed.
250m 20s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6375/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6375
Optional Tests javac javadoc unit compile shadedjars
uname Linux a96bd06cf324 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 726b2d8
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6375/1/testReport/
Max. process+thread count 4577 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6375/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia
Copy link
Contributor Author

Spotbugs failure is unrelated.

// TODO: Clean up split and merge. Currently all over the place.
try {
env.getMasterServices().getMasterQuotaManager().onRegionMerged(this.mergedRegion);
MasterQuotaManager masterQuotaManager = env.getMasterServices().getMasterQuotaManager();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mnpoonia in which case are you seeing this NPE? Master is starting up and quotas has not yet initialized?

Copy link
Contributor Author

@mnpoonia mnpoonia Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NihalJain You are right. A Master was in transition when we got this exception. It was trying to become active. Sequence of events were as noted below for reference

2024-10-14 20:02:11,265 ERROR [PEWorker-31] procedure2.ProcedureExecutor - CODE-BUG: Uncaught runtime exception: pid=58745238, state=RUNNABLE:SPLIT_TABLE_REGION_PRE_OPERATION, locked=true; SplitTableRegionProcedure table=Table1, parent=36dcdeb9044bd0ece2eb046cf7fd7c2f, daughterA=cfba8d001ef9d3640060a4e845d3d013, daughterB=0becd69b7ccdc7e12dcc96cc637dc300
java.lang.NullPointerException

2024-10-14 20:02:11,269 INFO  [aster/hmaster-1:61000:becomeActiveMaster] quotas.MasterQuotaManager - Quota support disabled

@NihalJain
Copy link
Contributor

+1, LGTM

@mnpoonia
Copy link
Contributor Author

@NihalJain if everything is good. can you please help me in getting this committed upto branch-2.5.

@NihalJain
Copy link
Contributor

@NihalJain if everything is good. can you please help me in getting this committed upto branch-2.5.

Sure let me merge to master and ping back.

@NihalJain NihalJain merged commit ff9865a into apache:master Oct 24, 2024
1 check failed
@NihalJain
Copy link
Contributor

Merged. Thanks for the fix Aman. Could you please raise backports by cherry picking mfrom master.?

mnpoonia added a commit to mnpoonia/hbase that referenced this pull request Oct 24, 2024
mnpoonia added a commit to mnpoonia/hbase that referenced this pull request Oct 24, 2024
mnpoonia added a commit to mnpoonia/hbase that referenced this pull request Oct 24, 2024
NihalJain pushed a commit to NihalJain/hbase that referenced this pull request Oct 28, 2024
mnpoonia added a commit to mnpoonia/hbase that referenced this pull request Oct 28, 2024
NihalJain pushed a commit that referenced this pull request Oct 29, 2024
NihalJain pushed a commit that referenced this pull request Oct 29, 2024
NihalJain pushed a commit that referenced this pull request Oct 29, 2024
NihalJain pushed a commit that referenced this pull request Oct 29, 2024
@mnpoonia mnpoonia deleted the apache_quota_fix_NPE branch November 13, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants