- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.4k
HBASE-28928 Handle NPE in Split/Merge table when getMasterQuotaManager returns null #6375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 💔 -1 overall 
 
 This message was automatically generated. | 
| 🎊 +1 overall 
 
 This message was automatically generated. | 
| Spotbugs failure is unrelated. | 
| // TODO: Clean up split and merge. Currently all over the place. | ||
| try { | ||
| env.getMasterServices().getMasterQuotaManager().onRegionMerged(this.mergedRegion); | ||
| MasterQuotaManager masterQuotaManager = env.getMasterServices().getMasterQuotaManager(); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mnpoonia in which case are you seeing this NPE? Master is starting up and quotas has not yet initialized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NihalJain You are right. A Master was in transition when we got this exception. It was trying to become active. Sequence of events were as noted below for reference
2024-10-14 20:02:11,265 ERROR [PEWorker-31] procedure2.ProcedureExecutor - CODE-BUG: Uncaught runtime exception: pid=58745238, state=RUNNABLE:SPLIT_TABLE_REGION_PRE_OPERATION, locked=true; SplitTableRegionProcedure table=Table1, parent=36dcdeb9044bd0ece2eb046cf7fd7c2f, daughterA=cfba8d001ef9d3640060a4e845d3d013, daughterB=0becd69b7ccdc7e12dcc96cc637dc300
java.lang.NullPointerException
2024-10-14 20:02:11,269 INFO  [aster/hmaster-1:61000:becomeActiveMaster] quotas.MasterQuotaManager - Quota support disabled
| +1, LGTM | 
| @NihalJain if everything is good. can you please help me in getting this committed upto branch-2.5. | 
| 
 Sure let me merge to master and ping back. | 
| Merged. Thanks for the fix Aman. Could you please raise backports by cherry picking mfrom master.? | 
…r returns null (apache#6375) Signed-off-by: Nihal Jain <[email protected]>
…r returns null (apache#6375) Signed-off-by: Nihal Jain <[email protected]>
…r returns null (apache#6375) Signed-off-by: Nihal Jain <[email protected]>
…r returns null (apache#6375) Signed-off-by: Nihal Jain <[email protected]>
…r returns null (apache#6375) Signed-off-by: Nihal Jain <[email protected]>
…r returns null (#6375) (#6409) Signed-off-by: Nihal Jain <[email protected]>
…r returns null (#6375) (#6393) Signed-off-by: Nihal Jain <[email protected]>
…r returns null (#6375) (#6394) Signed-off-by: Nihal Jain <[email protected]>
…r returns null (#6375) (#6395) Signed-off-by: Nihal Jain <[email protected]>
No description provided.