Skip to content

Conversation

@gvprathyusha6
Copy link
Contributor

@gvprathyusha6 gvprathyusha6 commented Oct 17, 2024

This test currently fails intermittently in master branch, as startime is post reader creation
Elapsed time is sometimes 25074ms and sometimes 24994ms (but delay is 25000ms) since starttime was calculated after reader creation

@gvprathyusha6 gvprathyusha6 changed the title HBASE-28924 Create the start time right before creating the reader to calculate e… HBASE-28924 Create the start time right before creating the reader to calculate elapsedTime in testPrefetchWithDelay Oct 17, 2024
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 17s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 7s master passed
+1 💚 compile 2m 58s master passed
+1 💚 checkstyle 0m 39s master passed
-1 ❌ spotbugs 1m 37s /branch-spotbugs-hbase-server-warnings.html hbase-server in master has 1 extant spotbugs warnings.
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 54s the patch passed
+1 💚 compile 3m 3s the patch passed
+1 💚 javac 3m 3s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 37s the patch passed
+1 💚 spotbugs 1m 43s the patch passed
+1 💚 hadoopcheck 10m 32s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
35m 42s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6371/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6371
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 4b3b3dc2df97 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3994500
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6371/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor

apurtell commented Oct 17, 2024

@gvprathyusha6 Approved. The spotbugs warning is unrelated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 14s master passed
+1 💚 compile 0m 56s master passed
+1 💚 javadoc 0m 28s master passed
+1 💚 shadedjars 5m 45s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 4s the patch passed
+1 💚 compile 0m 57s the patch passed
+1 💚 javac 0m 57s the patch passed
+1 💚 javadoc 0m 27s the patch passed
+1 💚 shadedjars 5m 41s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 213m 26s /patch-unit-hbase-server.txt hbase-server in the patch failed.
239m 7s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6371/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6371
Optional Tests javac javadoc unit compile shadedjars
uname Linux ce932b5d984f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3994500
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6371/1/testReport/
Max. process+thread count 5285 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6371/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
Copy link
Contributor

The spotbugs warning is unrelated.

Raised HBASE-28927 for spotbugs, introduced in HBASE-28432. Sorry for the noise !

@apurtell apurtell merged commit 15e0905 into apache:master Oct 18, 2024
1 check failed
asfgit pushed a commit that referenced this pull request Oct 18, 2024
…lapsedTime in testPrefetchWithDelay (#6371)

Signed-off-by: Andrew Purtell <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
asfgit pushed a commit that referenced this pull request Oct 18, 2024
…lapsedTime in testPrefetchWithDelay (#6371)

Signed-off-by: Andrew Purtell <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
@NihalJain
Copy link
Contributor

Hi @apurtell just a heads up. Seems JIRA# somehow got lost during merge of this PR

apurtell pushed a commit to apurtell/hbase that referenced this pull request Oct 22, 2024
…lapsedTime in testPrefetchWithDelay (apache#6371)

Signed-off-by: Andrew Purtell <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Oct 22, 2024
…lapsedTime in testPrefetchWithDelay (apache#6371)

Signed-off-by: Andrew Purtell <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
asfgit pushed a commit that referenced this pull request Oct 22, 2024
…culate elapsedTime in testPrefetchWithDelay (#6371)"

This reverts commit 7154ca4.
asfgit pushed a commit that referenced this pull request Oct 22, 2024
asfgit pushed a commit that referenced this pull request Oct 22, 2024
…culate elapsedTime in testPrefetchWithDelay (#6371)"

This reverts commit 2b2996d.
asfgit pushed a commit that referenced this pull request Oct 22, 2024
asfgit pushed a commit that referenced this pull request Oct 22, 2024
…culate elapsedTime in testPrefetchWithDelay (#6371)"

This reverts commit 15e0905.
asfgit pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants