Skip to content

Conversation

@hgromer
Copy link
Contributor

@hgromer hgromer commented Oct 17, 2024

No description provided.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@hgromer
Copy link
Contributor Author

hgromer commented Oct 21, 2024

The spotbugs issues seems unrelated

Code | Warning
-- | --
DMI | Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][])
  | Bug type DMI_RANDOM_USED_ONLY_ONCE (click for details)In class org.apache.hadoop.hbase.util.LoadTestKVGeneratorIn method org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][])Called method java.util.Random.nextBytes(byte[])At LoadTestKVGenerator.java:[line 111]

Bad practice Warnings
Code	Warning
DMI	Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][])
[Bug type DMI_RANDOM_USED_ONLY_ONCE (click for details)](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6370/6/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html#DMI_RANDOM_USED_ONLY_ONCE)
In class org.apache.hadoop.hbase.util.LoadTestKVGenerator
In method org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][])
Called method java.util.Random.nextBytes(byte[])
At LoadTestKVGenerator.java:[line 111]

@Apache-HBase

This comment has been minimized.

@hgromer hgromer force-pushed the HBASE-27659 branch 2 times, most recently from e2c5386 to 69afa97 Compare October 22, 2024 19:52
@hgromer
Copy link
Contributor Author

hgromer commented Oct 22, 2024

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk
Copy link
Member

./hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackup.java:105:    try (Table ignored = TEST_UTIL.truncateTable(table1)) {:59: Must have at least one statement. [EmptyBlock]

well...

@ndimiduk
Copy link
Member

I guess checkstyle prefers

Table t = null;
try {
  t = TEST_UTIL.truncateTable(table1)
} finally {
  if (t != null) {
    t.close();
  }
}

This is getting silly.

@ndimiduk
Copy link
Member

Let's go back to TEST_UTIL.truncateTable(table1).close() for these cases where an underlying exception will result in no closable making it up to the calling context.

@hgromer hgromer force-pushed the HBASE-27659 branch 2 times, most recently from dd8d6c6 to 43c21e4 Compare January 22, 2025 14:40
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 2m 49s master passed
+1 💚 compile 3m 57s master passed
+1 💚 checkstyle 0m 53s master passed
+1 💚 spotbugs 2m 21s master passed
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 48s the patch passed
+1 💚 compile 3m 58s the patch passed
-0 ⚠️ javac 0m 27s /results-compile-javac-hbase-backup.txt hbase-backup generated 2 new + 102 unchanged - 0 fixed = 104 total (was 102)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 54s the patch passed
+1 💚 spotbugs 2m 44s the patch passed
+1 💚 hadoopcheck 10m 51s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
41m 3s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6370/29/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6370
JIRA Issue HBASE-27659
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 860b4ad17fc9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c8d87ac
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-server hbase-mapreduce hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6370/29/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 59s master passed
+1 💚 compile 1m 31s master passed
+1 💚 javadoc 0m 54s master passed
+1 💚 shadedjars 5m 43s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 53s the patch passed
+1 💚 compile 1m 31s the patch passed
+1 💚 javac 1m 31s the patch passed
+1 💚 javadoc 0m 53s the patch passed
+1 💚 shadedjars 5m 38s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 243m 10s hbase-server in the patch passed.
+1 💚 unit 25m 48s hbase-mapreduce in the patch passed.
+1 💚 unit 18m 27s hbase-backup in the patch passed.
316m 5s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6370/29/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6370
JIRA Issue HBASE-27659
Optional Tests javac javadoc unit compile shadedjars
uname Linux 0f3aff018244 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c8d87ac
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6370/29/testReport/
Max. process+thread count 4694 (vs. ulimit of 30000)
modules C: hbase-server hbase-mapreduce hbase-backup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6370/29/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks a lot for your patience, @hgromer .

@ndimiduk ndimiduk merged commit f98621a into apache:master Jan 23, 2025
1 check passed
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Jan 23, 2025
…ackup (apache#6370)

Co-authored-by: Hernan Gelaf-Romer <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Jan 23, 2025
…ackup (apache#6370)

Co-authored-by: Hernan Gelaf-Romer <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Jan 23, 2025
…ackup (apache#6370)

Co-authored-by: Hernan Gelaf-Romer <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>
mnpoonia pushed a commit to mnpoonia/hbase that referenced this pull request Jan 24, 2025
…ackup (apache#6370)

Co-authored-by: Hernan Gelaf-Romer <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>
mnpoonia pushed a commit to mnpoonia/hbase that referenced this pull request Jan 24, 2025
…ackup (apache#6370)

Co-authored-by: Hernan Gelaf-Romer <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>
ndimiduk pushed a commit that referenced this pull request Jan 24, 2025
…ackup (#6370)

Co-authored-by: Hernan Gelaf-Romer <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>
ndimiduk pushed a commit that referenced this pull request Jan 24, 2025
…ackup (#6370)

Co-authored-by: Hernan Gelaf-Romer <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>
ndimiduk pushed a commit that referenced this pull request Jan 24, 2025
…ackup (#6370)

Co-authored-by: Hernan Gelaf-Romer <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>
hgromer added a commit to HubSpot/hbase that referenced this pull request Feb 4, 2025
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
…ackup (apache#6370)

Co-authored-by: Hernan Gelaf-Romer <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants