Skip to content

HBASE-28001: Add request attribute support to BufferedMutator (#6076) (addendum) #6349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

HBASE-28001: Add request attribute support to BufferedMutator (#6076) (addendum) #6349

merged 1 commit into from
Oct 8, 2024

Conversation

@ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Oct 7, 2024

Add default implementations of the new methods so that a custom implementation of AsyncBufferedMutatorBuilder will not fail to compile after upgrade.

@ndimiduk
Copy link
Member Author

ndimiduk commented Oct 7, 2024

This PR introduces default interface implementations for the new methods. This is intended to address the high severity data type issues raised on the report generated for RC0. By my read of the policy outlined in our book, we need to apply this patch to branch-2 and branch-2.6. PTAL. @stoty @NihalJain @Apache9 @apurtell @eab148

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
stoty
stoty approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndimiduk
HBASE-28001: Add request attribute support to BufferedMutator (apache…
9321af0 
…#6076) (addendum)

Add default implementations of the new methods so that a custom implementation of
AsyncBufferedMutatorBuilder will not fail to compile after upgrade.
@ndimiduk ndimiduk force-pushed the 28001-addendum-branch-2.6 branch from 6f91c71 to 9321af0 Compare October 8, 2024 09:52
@ndimiduk
Copy link
Member Author

ndimiduk commented Oct 8, 2024

Fixing checkstyle complaint.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 57s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 2m 34s branch-2.6 passed
+1 💚 compile 0m 21s branch-2.6 passed
+1 💚 javadoc 0m 20s branch-2.6 passed
+1 💚 shadedjars 4m 52s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 25s the patch passed
+1 💚 compile 0m 21s the patch passed
+1 💚 javac 0m 21s the patch passed
+1 💚 javadoc 0m 17s the patch passed
+1 💚 shadedjars 4m 59s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 8m 13s hbase-client in the patch passed.
26m 44s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6349
JIRA Issue HBASE-28001
Optional Tests javac javadoc unit compile shadedjars
uname Linux 8c742cb28e49 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 9321af0
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/testReport/
Max. process+thread count 367 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 3m 10s branch-2.6 passed
+1 💚 compile 0m 25s branch-2.6 passed
+1 💚 javadoc 0m 23s branch-2.6 passed
+1 💚 shadedjars 5m 32s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 59s the patch passed
+1 💚 compile 0m 25s the patch passed
+1 💚 javac 0m 25s the patch passed
+1 💚 javadoc 0m 21s the patch passed
+1 💚 shadedjars 5m 30s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 8m 4s hbase-client in the patch passed.
28m 42s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6349
JIRA Issue HBASE-28001
Optional Tests javac javadoc unit compile shadedjars
uname Linux 6f7239c44720 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 9321af0
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/testReport/
Max. process+thread count 371 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 2m 50s branch-2.6 passed
+1 💚 compile 0m 48s branch-2.6 passed
+1 💚 checkstyle 0m 16s branch-2.6 passed
+1 💚 spotbugs 0m 48s branch-2.6 passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 50s the patch passed
+1 💚 compile 0m 48s the patch passed
+1 💚 javac 0m 48s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 16s the patch passed
+1 💚 spotbugs 0m 55s the patch passed
+1 💚 hadoopcheck 15m 36s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
29m 9s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6349
JIRA Issue HBASE-28001
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 19ec136cd951 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 9321af0
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 76 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 3m 16s branch-2.6 passed
+1 💚 compile 0m 22s branch-2.6 passed
+1 💚 javadoc 0m 19s branch-2.6 passed
+1 💚 shadedjars 6m 7s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 13s the patch passed
+1 💚 compile 0m 21s the patch passed
+1 💚 javac 0m 21s the patch passed
+1 💚 javadoc 0m 19s the patch passed
+1 💚 shadedjars 5m 57s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 8m 16s hbase-client in the patch passed.
30m 15s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6349
JIRA Issue HBASE-28001
Optional Tests javac javadoc unit compile shadedjars
uname Linux 87b27efbaa17 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 9321af0
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/testReport/
Max. process+thread count 360 (vs. ulimit of 30000)
modules C: hbase-client U: hbase-client
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6349/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit 53118fe into apache:branch-2.6 Oct 8, 2024
1 check passed
@ndimiduk ndimiduk deleted the 28001-addendum-branch-2.6 branch October 8, 2024 10:53
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Oct 8, 2024
@ndimiduk
HBASE-28001: Add request attribute support to BufferedMutator (apache…
6703f39 
…#6076) (addendum) (apache#6349)

Add default implementations of the new methods so that a custom implementation of
AsyncBufferedMutatorBuilder will not fail to compile after upgrade.

Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Istvan Toth <[email protected]>
ndimiduk added a commit that referenced this pull request Oct 8, 2024
@ndimiduk
HBASE-28001: Add request attribute support to BufferedMutator (#6076)…
eeed0ad 
… (addendum) (#6349)

Add default implementations of the new methods so that a custom implementation of
AsyncBufferedMutatorBuilder will not fail to compile after upgrade.

Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Istvan Toth <[email protected]>
@eab148
Copy link
Contributor

eab148 commented Oct 8, 2024

Thanks Nick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stoty stoty stoty approved these changes

@NihalJain NihalJain NihalJain approved these changes

@apurtell apurtell Awaiting requested review from apurtell

@Apache9 Apache9 Awaiting requested review from Apache9

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ndimiduk @Apache-HBase @eab148 @stoty @NihalJain