Skip to content

HBASE-28745 : Default Zookeeper ConnectionRegistry APIs timeout should be less #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2024
Merged

HBASE-28745 : Default Zookeeper ConnectionRegistry APIs timeout should be less #6104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
052b445
HBASE-28745 : Default Zookeeper ConnectionRegistry APIs timeout shoul…
Divneet18 Jul 19, 2024
18e6eda
updated zk connection registry time
Divneet18 Jul 19, 2024
241bf81
changed default time to 10 sec
Divneet18 Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class ZKConnectionRegistry implements ConnectionRegistry {
private final Configuration conf;
private final int zkRegistryAsyncTimeout;
public static final String ZK_REGISTRY_ASYNC_GET_TIMEOUT = "zookeeper.registry.async.get.timeout";
public static final int DEFAULT_ZK_REGISTRY_ASYNC_GET_TIMEOUT = 60000; // 1 min
public static final int DEFAULT_ZK_REGISTRY_ASYNC_GET_TIMEOUT = 10000; // 10 sec

// User not used, but for rpc based registry we need it
ZKConnectionRegistry(Configuration conf, User ignored) {
Expand Down
6 changes: 3 additions & 3 deletions hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestReadOnlyZKClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,9 @@ public void testNotCloseZkWhenPending() throws Exception {

@Test
public void testReadWithTimeout() throws Exception {
assertArrayEquals(DATA, RO_ZK.get(PATH, 60000).get());
assertEquals(CHILDREN, RO_ZK.exists(PATH, 60000).get().getNumChildren());
List<String> children = RO_ZK.list(PATH, 60000).get();
assertArrayEquals(DATA, RO_ZK.get(PATH, 10000).get());
assertEquals(CHILDREN, RO_ZK.exists(PATH, 10000).get().getNumChildren());
List<String> children = RO_ZK.list(PATH, 10000).get();
assertEquals(CHILDREN, children.size());
Collections.sort(children);
for (int i = 0; i < CHILDREN; i++) {
Expand Down