Skip to content

HBASE-28661 Fix compatibility issue in SecurityHeadersFilter in branch-2.x #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024
Merged

HBASE-28661 Fix compatibility issue in SecurityHeadersFilter in branch-2.x #5986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions hbase-http/src/main/java/org/apache/hadoop/hbase/http/SecurityHeadersFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,27 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
public void destroy() {
}

/**
* @param conf configuration
* @param isSecure use secure defaults if 'true'
* @return default parameters, as a map
*/
public static Map<String, String> getDefaultParameters(Configuration conf, boolean isSecure) {
Map<String, String> params = new HashMap<>();
params.put("hsts", conf.get("hbase.http.filter.hsts.value", isSecure ? DEFAULT_HSTS : ""));
params.put("csp", conf.get("hbase.http.filter.csp.value", isSecure ? DEFAULT_CSP : ""));
return params;
}

/**
* @param conf configuration
* @return default parameters, as a map
* @deprecated Use {@link SecurityHeadersFilter#getDefaultParameters(Configuration, boolean)}
* instead.
*/
@Deprecated
public static Map<String, String> getDefaultParameters(Configuration conf) {
return getDefaultParameters(conf, false);
}

}