-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28595: client side fix for partial results when exception from scan RPC is lost #5904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
4c30a9d to
9b9c9fc
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, IMO this is a clean client side fix.
@Apache9 I recalled on the JIRA HBASE-28595, you mentioned it should be a server-side fix, should we have a separate JIRA for the server side change?
nit: @csringhofer do you think you can write a unit test for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that in impala, you want a client which can work with any HBase server versions but in HBase, this should be a server issue so we should fix it at server side.
|
I am working on creating unit tests for this - after that creating a server side fix doesn't seem hard.
The main priority is to have something that is easy to backport to older branches and can't break anything. |
|
Uploaded a server side fix for master: Created a test that seemed consistent so far but had to modify RemoteWithExtrasException to make it work. I do not understand why this was needed. |
No description provided.