-
Couldn't load subscription status.
- Fork 3.4k
HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… #5802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Using Caffeine instead of Guava Cache, as recommended by Guava. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
|
Oops, this is actually two commits. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
| DEFAULT_REST_SCANNERCACHE_EXPIRE_TIME_MS, TimeUnit.MILLISECONDS); | ||
|
|
||
| Cache<String, ScannerInstanceResource> cache = | ||
| Caffeine.newBuilder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we are not using org.apache.hbase.thirdparty.com.google.common.cache.CacheBuilder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Guava documenatation itself suggests using this one instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is supposed to be better (though perf doesn't matter that much in this case), and the the docs imply that the Guava one is not actively developed anymore.
We already use this library elsewhere.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…vent scanner leakage Signed-off-by: Peter Somogyi <[email protected]> Change-Id: I6a2f3a6398a68297db91cb8980ce80085ecfd7cb
|
Ruined formatting by spotless. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…vent scanner leakage (#5802) Signed-off-by: Peter Somogyi <[email protected]>
…vent scanner leakage (#5802) Signed-off-by: Peter Somogyi <[email protected]>
…vent scanner leakage (#5802) Signed-off-by: Peter Somogyi <[email protected]>
…vent scanner leakage (#5802) Signed-off-by: Peter Somogyi <[email protected]>
…vent scanner leakage (#5802) Signed-off-by: Peter Somogyi <[email protected]>
…vent scanner leakage (apache#5802) Signed-off-by: Peter Somogyi <[email protected]>
…vent scanner leakage (apache#5802) Signed-off-by: Peter Somogyi <[email protected]> Change-Id: I7bd7b6991d69644024bdd34eb68cd70ec3aeafe4
…vent scanner leakage