Skip to content

HBASE-28345 Close HBase connection on exit from HBase Shell #5665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2024
+5 −0
Merged

HBASE-28345 Close HBase connection on exit from HBase Shell #5665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
041fea4
HBASE-28345 Close HBase connection on exit from HBase Shell
stoty Feb 6, 2024
6325199
remove self. as suggested by rubocop
stoty Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hbase-shell/src/main/ruby/shell.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,11 @@ class Shell
# exit the interactive shell and save that this
# happend via a call to exit
def exit(ret = 0)
# Non-deamon Netty threadpool in ZK ClientCnxnSocketNetty cannot be shut down otherwise
begin
hbase.shutdown
rescue Exception
end
@exit_code = ret
IRB.irb_exit(IRB.CurrentContext.irb, ret)
end
Expand Down