HBASE-25292 [branch-2.4] Improve InetSocketAddress usage discipline #5515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thank you. This is looking good to me but since I was involved in creating this patch I'll give @apurtell (or others) a chance to take a look as well. Thank you @sbernauer! |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Co-authored-by: Andrew Purtell <[email protected]> (cherry picked from commit f813479)
sbernauer
force-pushed
the
branch-2.4
branch
from
ddc046f to
c4dc0eb
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@sbernauer Thanks for opening this PR. So you guys needs this on branch-2.4? The patch here removes a configuration, so typically we do not want to include it in a patch release. And looking at the discussion on #2669 , there are also some other follow on tasks need to be done before making a release. Thanks. |
|
Yep, we find that without it, running 2.4.x on Kubernetes is very unstable across restarts because of DNS issues. We're also happy to just maintain the patch on our end for the rest of the lifecycle of 2.4 but thought others might benefit from this. Indeed, it removes a config and at least I didn't think about that when we put this PR up. Which other follow on tasks are you referring to? But as I mentioned: We can also close this PR if you're opposed to the change, we don't have very strong feelings about it. And thanks for taking a look! |
|
See HBASE-25335. I think at least we should also backport HBASE-25336? |
|
Ah! Yes, sorry. We have a patch for that as well and can put up a PR as well. Only makes sense if we agree that this one should go in though I believe. They might even depend on each other, I haven't checked now. |
|
I'm OK with backporting all these issues to 2.4. |
Apache9
approved these changes
Nov 24, 2023
|
Thank you! I'll merge it then and we'll get the second PR up as well. |
|
Thanks a lot for the quick review! |
|
Created #5537 as a follow-up |
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…pache#5515) Co-authored-by: Andrew Purtell <[email protected]> (cherry picked from commit f813479) (cherry picked from commit 8707793) Change-Id: Idef951d038f8bda6e74d57d2894323322cae3e86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-port of #2669 to the 2.4 release line.
(cherry picked from commit f813479)
Co-authored-by: Andrew Purtell [email protected]