HBASE-24179 Backport fix for "Netty SASL implementation does not wait for challenge response" to branch-2.x #5472

NihalJain · 2023-10-21T19:05:02Z

Backport HBASE-23881 "Netty SASL implementation does not wait for challenge response"
Backport HBASE-24263 "TestDelegationToken is broken"
Fix assertion to check for InvalidToken.class.getName() to ensure bug is fixed

…wait for challenge response" to branch-2

NihalJain · 2023-10-21T19:06:38Z

Created 3 different commits for each bullet point in description for easier review.

Apache-HBase · 2023-10-21T19:53:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 0s	branch-2 passed
+1 💚	compile	3m 24s	branch-2 passed
+1 💚	checkstyle	0m 55s	branch-2 passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 31s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	3m 22s	the patch passed
+1 💚	javac	3m 22s	the patch passed
+1 💚	checkstyle	0m 54s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 36s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 56s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		38m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5472/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5472
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ddb41fa9a640 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `6febf48`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-examples U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5472/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-21T23:17:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 16s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 28s	branch-2 passed
+1 💚	compile	1m 18s	branch-2 passed
+1 💚	shadedjars	4m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	1m 15s	the patch passed
+1 💚	javac	1m 15s	the patch passed
+1 💚	shadedjars	4m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 40s	hbase-client in the patch passed.
+1 💚	unit	207m 48s	hbase-server in the patch passed.
+1 💚	unit	2m 21s	hbase-examples in the patch passed.
		241m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5472/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5472
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4af096011fc2 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `6febf48`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5472/1/testReport/
Max. process+thread count	4617 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-examples U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5472/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-21T23:26:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 49s	branch-2 passed
+1 💚	compile	1m 26s	branch-2 passed
+1 💚	shadedjars	4m 59s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	1m 26s	the patch passed
+1 💚	javac	1m 26s	the patch passed
+1 💚	shadedjars	4m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 58s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 29s	hbase-client in the patch passed.
+1 💚	unit	215m 49s	hbase-server in the patch passed.
+1 💚	unit	1m 58s	hbase-examples in the patch passed.
		251m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5472/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5472
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 95977bc2cd0e 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `6febf48`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5472/1/testReport/
Max. process+thread count	4588 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server hbase-examples U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5472/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2023-10-25T08:19:01Z

@Apache9 need your heads up to pull this one to branch-2.5, and branch-2.4. Please let me know WDYT.

NihalJain · 2023-10-31T13:53:01Z

@Apache9 need your heads up to pull this one to branch-2.5, and branch-2.4. Please let me know WDYT.

gentle ping @Apache9

Apache9 · 2023-11-01T08:37:53Z

@Apache9 need your heads up to pull this one to branch-2.5, and branch-2.4. Please let me know WDYT.

If this is a bug I think we should include them in 2.5.x and 2.4.x.

… for challenge response" to branch-2.x (apache#5472) - Backport HBASE-23881 "Netty SASL implementation does not wait for challenge response" - Backport HBASE-24263 "TestDelegationToken is broken" - Fix assertion to check for InvalidToken.class.getName() to ensure bug is fixed

… for challenge response" to branch-2.x (#5472) (#5496) - Backport HBASE-23881 "Netty SASL implementation does not wait for challenge response" - Backport HBASE-24263 "TestDelegationToken is broken" - Fix assertion to check for InvalidToken.class.getName() to ensure bug is fixed Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>

… for challenge response" to branch-2.x (#5472) (#5497) - Backport HBASE-23881 "Netty SASL implementation does not wait for challenge response" - Backport HBASE-24263 "TestDelegationToken is broken" - Fix assertion to check for InvalidToken.class.getName() to ensure bug is fixed Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>

… for challenge response" to branch-2.x (apache#5472) - Backport HBASE-23881 "Netty SASL implementation does not wait for challenge response" - Backport HBASE-24263 "TestDelegationToken is broken" - Fix assertion to check for InvalidToken.class.getName() to ensure bug is fixed Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3481aef) Change-Id: I2b162e55330245e7fe05c08b630360f957b3c862

…tation does not wait for challenge response" to branch-2.x (apache#5472)" This reverts commit 7fe84fc. Change-Id: I8947dda5e3236ce25ca37b9994aaf69984a518af

…tation does not wait for challenge response" to branch-2.x (apache#5472)" This reverts commit 3481aef. Change-Id: I518975a4fd1d83e1f492b3cadb23c56099a464bf

…not wait for challenge response" to branch-2.x (apache#5472)" This reverts commit 3481aef. Change-Id: If509f3a05cad343e7594be6b44b2ce6980a96ecc

NihalJain added 3 commits October 22, 2023 00:17

HBASE-24179 Backport HBASE-23881 "Netty SASL implementation does not …

1885af7

…wait for challenge response" to branch-2

Backport HBASE-24263 "TestDelegationToken is broken"

8d1a187

Update the test assertion after bug fix

4f739ee

NihalJain requested a review from Apache9 October 21, 2023 19:05

NihalJain changed the title ~~HBASE-24179 Backport Netty SASL implementation does not wait for challenge response~~ HBASE-24179 Backport fix for "Netty SASL implementation does not wait for challenge response" to branch-2.x Oct 21, 2023

NihalJain requested a review from joshelser October 22, 2023 03:36

Apache9 approved these changes Oct 22, 2023

View reviewed changes

NihalJain merged commit 3481aef into apache:branch-2 Oct 25, 2023

NihalJain mentioned this pull request Nov 2, 2023

HBASE-24179 Backport fix for "Netty SASL implementation does not wait… #5496

Merged

NihalJain mentioned this pull request Nov 2, 2023

HBASE-24179 Backport fix for "Netty SASL implementation does not wait… #5497

Merged

szucsvillo mentioned this pull request Jun 20, 2024

Revert "HBASE-24179 Backport fix for "Netty SASL implementation does … szucsvillo/hbase#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

HBASE-24179 Backport fix for "Netty SASL implementation does not wait for challenge response" to branch-2.x #5472

HBASE-24179 Backport fix for "Netty SASL implementation does not wait for challenge response" to branch-2.x #5472

Uh oh!

NihalJain commented Oct 21, 2023

Uh oh!

NihalJain commented Oct 21, 2023

Uh oh!

Apache-HBase commented Oct 21, 2023

Uh oh!

Apache-HBase commented Oct 21, 2023

Uh oh!

Apache-HBase commented Oct 21, 2023

Uh oh!

NihalJain commented Oct 25, 2023

Uh oh!

NihalJain commented Oct 31, 2023

Uh oh!

Apache9 commented Nov 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

HBASE-24179 Backport fix for "Netty SASL implementation does not wait for challenge response" to branch-2.x #5472

HBASE-24179 Backport fix for "Netty SASL implementation does not wait for challenge response" to branch-2.x #5472

Uh oh!

Conversation

NihalJain commented Oct 21, 2023

Uh oh!

NihalJain commented Oct 21, 2023

Uh oh!

Apache-HBase commented Oct 21, 2023

Uh oh!

Apache-HBase commented Oct 21, 2023

Uh oh!

Apache-HBase commented Oct 21, 2023

Uh oh!

NihalJain commented Oct 25, 2023

Uh oh!

NihalJain commented Oct 31, 2023

Uh oh!

Apache9 commented Nov 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants