Skip to content

HBASE-28144 Canary publish read failure fails with NPE if region location is null #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023
Merged

HBASE-28144 Canary publish read failure fails with NPE if region location is null #5456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,13 +323,15 @@ public void resetFailuresCountDetails() {
}

private void incFailuresCountDetails(ServerName serverName, RegionInfo region) {
perServerFailuresCount.compute(serverName, (server, count) -> {
if (count == null) {
count = new LongAdder();
}
count.increment();
return count;
});
if (serverName != null) {
perServerFailuresCount.compute(serverName, (server, count) -> {
if (count == null) {
count = new LongAdder();
}
count.increment();
return count;
});
}
perTableFailuresCount.compute(region.getTable().getNameAsString(), (tableName, count) -> {
if (count == null) {
count = new LongAdder();
Expand All @@ -340,18 +342,18 @@ private void incFailuresCountDetails(ServerName serverName, RegionInfo region) {
}

public void publishReadFailure(ServerName serverName, RegionInfo region, Exception e) {
incReadFailureCount();
incFailuresCountDetails(serverName, region);
LOG.error("Read from {} on serverName={} failed", region.getRegionNameAsString(), serverName,
e);
incReadFailureCount();
incFailuresCountDetails(serverName, region);
}

public void publishReadFailure(ServerName serverName, RegionInfo region,
ColumnFamilyDescriptor column, Exception e) {
incReadFailureCount();
incFailuresCountDetails(serverName, region);
LOG.error("Read from {} on serverName={}, columnFamily={} failed",
region.getRegionNameAsString(), serverName, column.getNameAsString(), e);
incReadFailureCount();
incFailuresCountDetails(serverName, region);
}

public void publishReadTiming(ServerName serverName, RegionInfo region,
Expand All @@ -368,17 +370,17 @@ public void publishReadTiming(ServerName serverName, RegionInfo region,
}

public void publishWriteFailure(ServerName serverName, RegionInfo region, Exception e) {
LOG.error("Write to {} on {} failed", region.getRegionNameAsString(), serverName, e);
incWriteFailureCount();
incFailuresCountDetails(serverName, region);
LOG.error("Write to {} on {} failed", region.getRegionNameAsString(), serverName, e);
}

public void publishWriteFailure(ServerName serverName, RegionInfo region,
ColumnFamilyDescriptor column, Exception e) {
incWriteFailureCount();
incFailuresCountDetails(serverName, region);
LOG.error("Write to {} on {} {} failed", region.getRegionNameAsString(), serverName,
column.getNameAsString(), e);
incWriteFailureCount();
incFailuresCountDetails(serverName, region);
}

public void publishWriteTiming(ServerName serverName, RegionInfo region,
Expand Down