Skip to content

HBASE-28135 Specify -Xms for tests #5451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2023
Merged

HBASE-28135 Specify -Xms for tests #5451

merged 3 commits into from
Oct 12, 2023

Conversation

@stoty
Copy link
Contributor

@stoty stoty commented Oct 6, 2023

Change-Id: I45a17ac34b12aa00a04341413ac01dc70e5f328b

@stoty
HBASE-28135 Specify -Xms for tests
2c67cac 
Change-Id: I45a17ac34b12aa00a04341413ac01dc70e5f328b
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache9
Copy link
Contributor

Apache9 commented Oct 6, 2023

Can we use surefire.Xms instead of a hard coded one?

@stoty
use property for Xms size
0a3ab27 
Change-Id: Ie62e21432978ead6efd4100160f6faed8356ff17
@stoty
Copy link
Contributor Author

stoty commented Oct 6, 2023

Sure, I have added the property.

@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 46s master passed
+1 💚 compile 6m 10s master passed
+1 💚 spotless 0m 54s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 16s the patch passed
+1 💚 compile 6m 9s the patch passed
+1 💚 javac 6m 9s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 13m 8s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 56s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
42m 48s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5451
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux 3ff29a0e75e2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / eb24001
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 59s master passed
+1 💚 compile 4m 44s master passed
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 40s the patch passed
+1 💚 compile 4m 51s the patch passed
+1 💚 javac 4m 51s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 9m 39s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
32m 32s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5451
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux 02502ba0800b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f15ff5b
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 75 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi
Copy link
Contributor

The pre-commit checks timed out for the second and third builds. Only the general checks completed which do not trigger unit tests.

@stoty
fix syntax error
38efda4 
Change-Id: I0721e66493869aa597152c9eeeac96b9275b0485
@stoty
Copy link
Contributor Author

stoty commented Oct 11, 2023

You are right, the variable substitutions were missing the dollar sign.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 24s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 30s master passed
+1 💚 compile 4m 39s master passed
+1 💚 spotless 0m 39s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 32s the patch passed
+1 💚 compile 4m 39s the patch passed
+1 💚 javac 4m 39s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 9m 23s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 39s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
31m 32s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5451
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux 14117978624f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0d15d03
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 73 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 14s master passed
+1 💚 compile 2m 40s master passed
+1 💚 shadedjars 6m 0s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 26s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 37s the patch passed
+1 💚 compile 1m 57s the patch passed
+1 💚 javac 1m 57s the patch passed
+1 💚 shadedjars 4m 48s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 54s the patch passed
_ Other Tests _
+1 💚 unit 278m 13s root in the patch passed.
311m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5451
Optional Tests javac javadoc unit shadedjars compile
uname Linux b71757942341 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0d15d03
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/testReport/
Max. process+thread count 8094 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 14s master passed
+1 💚 compile 1m 30s master passed
+1 💚 shadedjars 5m 11s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 21s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 16s the patch passed
+1 💚 compile 1m 30s the patch passed
+1 💚 javac 1m 30s the patch passed
+1 💚 shadedjars 5m 8s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 21s the patch passed
_ Other Tests _
+1 💚 unit 405m 38s root in the patch passed.
432m 22s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5451
Optional Tests javac javadoc unit shadedjars compile
uname Linux ce8f2231d446 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0d15d03
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/testReport/
Max. process+thread count 8444 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi petersomogyi merged commit 2568222 into apache:master Oct 12, 2023
petersomogyi pushed a commit that referenced this pull request Oct 12, 2023
@stoty @petersomogyi
HBASE-28135 Specify -Xms for tests (#5451)
e915e1c 
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Peter Somogyi <[email protected]>
petersomogyi pushed a commit that referenced this pull request Oct 12, 2023
@stoty @petersomogyi
HBASE-28135 Specify -Xms for tests (#5451)
abdc8cf 
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Peter Somogyi <[email protected]>
petersomogyi pushed a commit that referenced this pull request Oct 12, 2023
@stoty @petersomogyi
HBASE-28135 Specify -Xms for tests (#5451)
6a4a0b7 
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Peter Somogyi <[email protected]>
petersomogyi pushed a commit that referenced this pull request Oct 12, 2023
@stoty @petersomogyi
HBASE-28135 Specify -Xms for tests (#5451)
212c7cb 
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Peter Somogyi <[email protected]>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Nov 2, 2023
@stoty @wchevreuil
HBASE-28135 Specify -Xms for tests (apache#5451)
19187a3 
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Peter Somogyi <[email protected]>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@stoty @petersomogyi
HBASE-28135 Specify -Xms for tests (apache#5451)
e1ffb6b 
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Peter Somogyi <[email protected]>
(cherry picked from commit abdc8cf)
Change-Id: Ia2445bfb15fb37973e57bbcbbf74e16937dfc855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyi petersomogyi petersomogyi approved these changes

@Apache9 Apache9 Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stoty @Apache-HBase @Apache9 @petersomogyi