Skip to content

HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking #5388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2024
Merged

HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking #5388

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cc13cb
prohibit user from set hbase.server.allocator.buffer.size to non-posi…
teamconfx Sep 11, 2023
7b8f45c
add warning message if user choose to always allocated byte buffer fr…
teamconfx Sep 11, 2023
65e7709
use spotless apply to fix the style error
teamconfx Sep 11, 2023
6b334ee
check negative value for minSizeForReservoirUse
teamconfx Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,19 @@ public static ByteBuffAllocator create(Configuration conf, boolean reservoirEnab
// that by the time a handler originated response is actually done writing to socket and so
// released the BBs it used, the handler might have processed one more read req. On an avg 2x
// we consider and consider that also for the max buffers to pool
if (poolBufSize <= 0) {
throw new IllegalArgumentException(BUFFER_SIZE_KEY + " must be positive. Please disable "
+ "the reservoir rather than setting the size of the buffer to zero or negative.");
}
int bufsForTwoMB = (2 * 1024 * 1024) / poolBufSize;
int maxBuffCount =
conf.getInt(MAX_BUFFER_COUNT_KEY, conf.getInt(HConstants.REGION_SERVER_HANDLER_COUNT,
HConstants.DEFAULT_REGION_SERVER_HANDLER_COUNT) * bufsForTwoMB * 2);
int minSizeForReservoirUse = conf.getInt(MIN_ALLOCATE_SIZE_KEY, poolBufSize / 6);
if (minSizeForReservoirUse <= 0) {
LOG.warn("The minimal size for reservoir use is less or equal to zero, all allocations "
+ "will be from the pool. Set a higher " + MIN_ALLOCATE_SIZE_KEY + " to avoid this.");
}
Class<?> clazz = conf.getClass(BYTEBUFF_ALLOCATOR_CLASS, ByteBuffAllocator.class);
return (ByteBuffAllocator) ReflectionUtils.newInstance(clazz, true, maxBuffCount, poolBufSize,
minSizeForReservoirUse);
Expand Down