Skip to content

HBASE-26867 Introduce a FlushProcedure #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 28, 2023
Merged

HBASE-26867 Introduce a FlushProcedure #5353

merged 6 commits into from
Aug 28, 2023

Conversation

@frostruan
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 24s branch-2 passed
+1 💚 compile 6m 33s branch-2 passed
+1 💚 checkstyle 1m 44s branch-2 passed
+1 💚 spotless 0m 56s branch has no errors when running spotless:check.
+1 💚 spotbugs 7m 15s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 28s the patch passed
+1 💚 compile 6m 31s the patch passed
+1 💚 cc 6m 31s the patch passed
+1 💚 javac 6m 31s the patch passed
+1 💚 checkstyle 1m 53s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 16m 13s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.
+1 💚 hbaseprotoc 1m 59s the patch passed
+1 💚 spotless 0m 45s patch has no errors when running spotless:check.
+1 💚 spotbugs 7m 10s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
62m 43s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5353
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux 091a75a69304 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bf945f2
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 80 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 46s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 2m 37s branch-2 passed
+1 💚 compile 1m 47s branch-2 passed
+1 💚 shadedjars 4m 43s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 16s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 10s the patch passed
+1 💚 compile 1m 46s the patch passed
+1 💚 javac 1m 46s the patch passed
+1 💚 shadedjars 4m 40s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 14s the patch passed
_ Other Tests _
+1 💚 unit 0m 24s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 17s hbase-common in the patch passed.
+1 💚 unit 7m 24s hbase-client in the patch passed.
+1 💚 unit 206m 41s hbase-server in the patch passed.
+1 💚 unit 7m 27s hbase-thrift in the patch passed.
250m 30s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux 59a48db29893 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bf945f2
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/1/testReport/
Max. process+thread count 4019 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 23s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 2m 55s branch-2 passed
+1 💚 compile 2m 4s branch-2 passed
+1 💚 shadedjars 5m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 26s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 2m 31s the patch passed
+1 💚 compile 2m 4s the patch passed
+1 💚 javac 2m 4s the patch passed
+1 💚 shadedjars 5m 1s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 25s the patch passed
_ Other Tests _
+1 💚 unit 0m 29s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 10s hbase-common in the patch passed.
+1 💚 unit 8m 1s hbase-client in the patch passed.
+1 💚 unit 203m 0s hbase-server in the patch passed.
+1 💚 unit 6m 58s hbase-thrift in the patch passed.
251m 11s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux d887575c0fcc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bf945f2
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/1/testReport/
Max. process+thread count 4925 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed Aug 17, 2023
View reviewed changes
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java Outdated
// the hbase hadoop version does not match the running hadoop version or
// the FlushTableProcedure is disabled, if that happens, we need fall back
// to the old flush implementation.
legacyFlush(tableName, columnFamilies);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So when users call flushAsync directly, we can not fallback to legacyFlush automatically?

@Apache9
Copy link
Contributor

Apache9 commented Aug 22, 2023

@frostruan Any updates here?

Thanks.

@frostruan
Copy link
Contributor Author

Sorry, Duo, I don't know what I should update here. If you mean the problem that the legacyFlush method can not fallback, I have already replied and explained my thoughts, would you mind looking it first? :)

@Apache9
Copy link
Contributor

Apache9 commented Aug 22, 2023

I can not see your reply, maybe you forget to push the submit button?

@frostruan
Copy link
Contributor Author

oh sorry ... have no idea what went wrong, so let me copy the reply here.

Yes. From the perspective of fallback, it's better to make flushAsync method private in HBaseAdmin, but I introduce this method in Admin interface based on the following consideration
a. it is not a good practice to call asynchronous functions in a synchronous api
b. it still works if the master supports and enables FlushTablePRocedure
c. if an unsupported exception is thrown, the user can perceive it and handle it in the upper layer, just like a normal IOException.

@Apache9
Copy link
Contributor

Apache9 commented Aug 22, 2023

oh sorry ... have no idea what went wrong, so let me copy the reply here.

Yes. From the perspective of fallback, it's better to make flushAsync method private in HBaseAdmin, but I introduce this method in Admin interface based on the following consideration a. it is not a good practice to call asynchronous functions in a synchronous api b. it still works if the master supports and enables FlushTablePRocedure c. if an unsupported exception is thrown, the user can perceive it and handle it in the upper layer, just like a normal IOException.

XXXAsync methods are common in the Admin interface so we should provide it.

And how could our users handle the unsupported exception in upper layer? We do not expose the legacyFlush method to them, they can only retry on the same method and then get the same exception again?

@frostruan
Copy link
Contributor Author

oh sorry ... have no idea what went wrong, so let me copy the reply here.
Yes. From the perspective of fallback, it's better to make flushAsync method private in HBaseAdmin, but I introduce this method in Admin interface based on the following consideration a. it is not a good practice to call asynchronous functions in a synchronous api b. it still works if the master supports and enables FlushTablePRocedure c. if an unsupported exception is thrown, the user can perceive it and handle it in the upper layer, just like a normal IOException.

XXXAsync methods are common in the Admin interface so we should provide it.

And how could our users handle the unsupported exception in upper layer? We do not expose the legacyFlush method to them, they can only retry on the same method and then get the same exception again?

Our user can fallback to the old flush implementation by calling flush method. If our users really need asynchronous calls, maybe we can suggest them to consider AsyncHBaseAdmin#flush API in the doc.

Do you think it is necessary for us to implement fallback logic in the HBaseAdmin#flushAsync method?

@Apache9
Copy link
Contributor

Apache9 commented Aug 22, 2023

oh sorry ... have no idea what went wrong, so let me copy the reply here.
Yes. From the perspective of fallback, it's better to make flushAsync method private in HBaseAdmin, but I introduce this method in Admin interface based on the following consideration a. it is not a good practice to call asynchronous functions in a synchronous api b. it still works if the master supports and enables FlushTablePRocedure c. if an unsupported exception is thrown, the user can perceive it and handle it in the upper layer, just like a normal IOException.

XXXAsync methods are common in the Admin interface so we should provide it.
And how could our users handle the unsupported exception in upper layer? We do not expose the legacyFlush method to them, they can only retry on the same method and then get the same exception again?

Our user can fallback to the old flush implementation by calling flush method. If our users really need asynchronous calls, maybe we can suggest them to consider AsyncHBaseAdmin#flush API in the doc.

Do you think it is necessary for us to implement fallback logic in the HBaseAdmin#flushAsync method?

It will be confusing to users that flush and flushAsync are different. We should support the fallback logic also in flushAsync.

@frostruan
Copy link
Contributor Author

oh sorry ... have no idea what went wrong, so let me copy the reply here.
Yes. From the perspective of fallback, it's better to make flushAsync method private in HBaseAdmin, but I introduce this method in Admin interface based on the following consideration a. it is not a good practice to call asynchronous functions in a synchronous api b. it still works if the master supports and enables FlushTablePRocedure c. if an unsupported exception is thrown, the user can perceive it and handle it in the upper layer, just like a normal IOException.

XXXAsync methods are common in the Admin interface so we should provide it.
And how could our users handle the unsupported exception in upper layer? We do not expose the legacyFlush method to them, they can only retry on the same method and then get the same exception again?

Our user can fallback to the old flush implementation by calling flush method. If our users really need asynchronous calls, maybe we can suggest them to consider AsyncHBaseAdmin#flush API in the doc.
Do you think it is necessary for us to implement fallback logic in the HBaseAdmin#flushAsync method?

It will be confusing to users that flush and flushAsync are different. We should support the fallback logic also in flushAsync.

Ok. Let me fix this. Thanks Duo.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 2m 35s branch-2 passed
+1 💚 compile 5m 1s branch-2 passed
+1 💚 checkstyle 1m 44s branch-2 passed
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
+1 💚 spotbugs 5m 50s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 33s the patch passed
+1 💚 compile 5m 1s the patch passed
+1 💚 cc 5m 1s the patch passed
+1 💚 javac 5m 1s the patch passed
+1 💚 checkstyle 1m 43s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 20s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.
+1 💚 hbaseprotoc 1m 51s the patch passed
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
-1 ❌ spotbugs 1m 3s hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
52m 13s
Reason Tests
FindBugs module:hbase-client
Dead store to resp in org.apache.hadoop.hbase.client.HBaseAdmin.flushAsync(TableName, List) At HBaseAdmin.java:org.apache.hadoop.hbase.client.HBaseAdmin.flushAsync(TableName, List) At HBaseAdmin.java:[line 1297]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5353
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux 4409965bd827 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fbd258f
Default Java Eclipse Adoptium-11.0.17+8
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/2/artifact/yetus-general-check/output/new-spotbugs-hbase-client.html
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 43s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 2m 9s branch-2 passed
+1 💚 compile 1m 46s branch-2 passed
+1 💚 shadedjars 4m 39s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 13s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 9s the patch passed
+1 💚 compile 1m 51s the patch passed
+1 💚 javac 1m 51s the patch passed
+1 💚 shadedjars 4m 38s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 13s the patch passed
_ Other Tests _
+1 💚 unit 0m 22s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 15s hbase-common in the patch passed.
+1 💚 unit 7m 24s hbase-client in the patch passed.
+1 💚 unit 204m 51s hbase-server in the patch passed.
+1 💚 unit 7m 29s hbase-thrift in the patch passed.
247m 43s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux 82a668668275 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fbd258f
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/2/testReport/
Max. process+thread count 4222 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 49s branch-2 passed
+1 💚 compile 2m 26s branch-2 passed
+1 💚 shadedjars 4m 48s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 42s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 2m 45s the patch passed
+1 💚 compile 2m 27s the patch passed
+1 💚 javac 2m 27s the patch passed
+1 💚 shadedjars 4m 44s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 40s the patch passed
_ Other Tests _
+1 💚 unit 0m 36s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 10s hbase-common in the patch passed.
+1 💚 unit 8m 20s hbase-client in the patch passed.
+1 💚 unit 215m 8s hbase-server in the patch passed.
+1 💚 unit 7m 48s hbase-thrift in the patch passed.
264m 9s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux 515d9650961a 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fbd258f
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/2/testReport/
Max. process+thread count 4727 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 37s branch-2 passed
+1 💚 compile 4m 57s branch-2 passed
+1 💚 checkstyle 1m 44s branch-2 passed
-1 ❌ spotless 0m 37s branch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 5m 40s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 37s the patch passed
+1 💚 compile 5m 3s the patch passed
+1 💚 cc 5m 3s the patch passed
+1 💚 javac 5m 3s the patch passed
+1 💚 checkstyle 1m 41s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 16s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.
+1 💚 hbaseprotoc 1m 51s the patch passed
-1 ❌ spotless 0m 36s patch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 6m 30s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
51m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5353
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux 532455fd52bd 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7dfc2f3
Default Java Eclipse Adoptium-11.0.17+8
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/artifact/yetus-general-check/output/branch-spotless.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 43s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 2m 8s branch-2 passed
+1 💚 compile 1m 44s branch-2 passed
+1 💚 shadedjars 4m 37s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 13s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 8s the patch passed
+1 💚 compile 1m 47s the patch passed
+1 💚 javac 1m 47s the patch passed
+1 💚 shadedjars 4m 45s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 14s the patch passed
_ Other Tests _
+1 💚 unit 0m 23s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 13s hbase-common in the patch passed.
+1 💚 unit 7m 29s hbase-client in the patch passed.
-1 ❌ unit 211m 17s hbase-server in the patch failed.
+1 💚 unit 7m 30s hbase-thrift in the patch passed.
254m 24s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux e33684033b62 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7dfc2f3
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/testReport/
Max. process+thread count 4208 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 36s branch-2 passed
+1 💚 compile 2m 26s branch-2 passed
+1 💚 shadedjars 4m 46s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 40s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 32s the patch passed
+1 💚 compile 2m 25s the patch passed
+1 💚 javac 2m 25s the patch passed
+1 💚 shadedjars 4m 45s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 40s the patch passed
_ Other Tests _
+1 💚 unit 0m 34s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 11s hbase-common in the patch passed.
+1 💚 unit 8m 13s hbase-client in the patch passed.
+1 💚 unit 232m 41s hbase-server in the patch passed.
+1 💚 unit 8m 31s hbase-thrift in the patch passed.
281m 44s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux 778177ec1a75 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7dfc2f3
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/testReport/
Max. process+thread count 4632 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 1s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 2m 35s branch-2 passed
+1 💚 compile 4m 58s branch-2 passed
+1 💚 checkstyle 1m 43s branch-2 passed
-1 ❌ spotless 0m 38s branch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 5m 45s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 35s the patch passed
+1 💚 compile 4m 57s the patch passed
+1 💚 cc 4m 57s the patch passed
+1 💚 javac 4m 57s the patch passed
+1 💚 checkstyle 1m 44s the patch passed
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 13m 18s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.
+1 💚 hbaseprotoc 1m 51s the patch passed
-1 ❌ spotless 0m 21s patch has 22 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 6m 28s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
51m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5353
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux ee02f5981431 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2b46973
Default Java Eclipse Adoptium-11.0.17+8
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/artifact/yetus-general-check/output/branch-spotless.txt
whitespace https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/artifact/yetus-general-check/output/whitespace-eol.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 41s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 2m 11s branch-2 passed
+1 💚 compile 1m 50s branch-2 passed
+1 💚 shadedjars 4m 49s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 13s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 8s the patch passed
+1 💚 compile 1m 49s the patch passed
+1 💚 javac 1m 49s the patch passed
+1 💚 shadedjars 4m 44s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 14s the patch passed
_ Other Tests _
+1 💚 unit 0m 23s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 16s hbase-common in the patch passed.
+1 💚 unit 7m 24s hbase-client in the patch passed.
+1 💚 unit 207m 26s hbase-server in the patch passed.
+1 💚 unit 7m 31s hbase-thrift in the patch passed.
251m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux 737ead540970 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2b46973
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/testReport/
Max. process+thread count 4020 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 47s branch-2 passed
+1 💚 compile 2m 28s branch-2 passed
+1 💚 shadedjars 4m 46s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 40s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 2m 35s the patch passed
+1 💚 compile 2m 27s the patch passed
+1 💚 javac 2m 27s the patch passed
+1 💚 shadedjars 4m 46s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 40s the patch passed
_ Other Tests _
+1 💚 unit 0m 35s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 9s hbase-common in the patch passed.
+1 💚 unit 8m 15s hbase-client in the patch passed.
+1 💚 unit 214m 34s hbase-server in the patch passed.
+1 💚 unit 7m 46s hbase-thrift in the patch passed.
262m 58s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4e13835e0e0f 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2b46973
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/testReport/
Max. process+thread count 4732 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 50s branch-2 passed
+1 💚 compile 5m 0s branch-2 passed
+1 💚 checkstyle 1m 45s branch-2 passed
-1 ❌ spotless 0m 38s branch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 5m 49s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 2m 41s the patch passed
+1 💚 compile 4m 56s the patch passed
+1 💚 cc 4m 56s the patch passed
+1 💚 javac 4m 56s the patch passed
+1 💚 checkstyle 1m 43s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 11s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.
+1 💚 hbaseprotoc 1m 53s the patch passed
-1 ❌ spotless 0m 37s patch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 6m 30s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
51m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5353
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux 787c952009d6 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2b46973
Default Java Eclipse Adoptium-11.0.17+8
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/5/artifact/yetus-general-check/output/branch-spotless.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/5/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/5/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 2m 6s branch-2 passed
+1 💚 compile 1m 45s branch-2 passed
+1 💚 shadedjars 4m 40s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 13s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 9s the patch passed
+1 💚 compile 1m 47s the patch passed
+1 💚 javac 1m 47s the patch passed
+1 💚 shadedjars 4m 41s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 15s the patch passed
_ Other Tests _
+1 💚 unit 0m 23s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 15s hbase-common in the patch passed.
+1 💚 unit 7m 28s hbase-client in the patch passed.
+1 💚 unit 206m 39s hbase-server in the patch passed.
+1 💚 unit 7m 41s hbase-thrift in the patch passed.
250m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5316958ca665 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2b46973
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/5/testReport/
Max. process+thread count 4177 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/5/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 38s branch-2 passed
+1 💚 compile 2m 25s branch-2 passed
+1 💚 shadedjars 4m 45s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 39s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 32s the patch passed
+1 💚 compile 2m 23s the patch passed
+1 💚 javac 2m 23s the patch passed
+1 💚 shadedjars 4m 46s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 41s the patch passed
_ Other Tests _
+1 💚 unit 0m 34s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 10s hbase-common in the patch passed.
+1 💚 unit 8m 14s hbase-client in the patch passed.
+1 💚 unit 237m 44s hbase-server in the patch passed.
+1 💚 unit 7m 48s hbase-thrift in the patch passed.
286m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux 93a682847192 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2b46973
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/5/testReport/
Max. process+thread count 4808 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/5/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Aug 27, 2023

Please fix the spotless error?

Thanks.

@frostruan
Copy link
Contributor Author

Yes, I am working on fixing this problem. I executed the mvn spotless:apply before the last three commits, and this patch does not involve the problematic file. A bit strange .... let me dig more :)

@Apache9
Copy link
Contributor

Apache9 commented Aug 27, 2023

Maybe it is because others merged a PR without fixing all the spotless issues...

@frostruan
Copy link
Contributor Author

Very possible. Let me check the git log.

@frostruan frostruan force-pushed the branch-2-HBASE-26867 branch from 3540597 to b722b2b Compare August 27, 2023 15:34
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 30s branch-2 passed
+1 💚 compile 7m 12s branch-2 passed
+1 💚 checkstyle 2m 5s branch-2 passed
-1 ❌ spotless 0m 41s branch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 6m 51s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 29s the patch passed
+1 💚 compile 5m 56s the patch passed
+1 💚 cc 5m 56s the patch passed
+1 💚 javac 5m 56s the patch passed
+1 💚 checkstyle 0m 7s The patch passed checkstyle in hbase-protocol-shaded
+1 💚 checkstyle 0m 19s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 21s The patch passed checkstyle in hbase-client
+1 💚 checkstyle 0m 42s hbase-server: The patch generated 0 new + 16 unchanged - 1 fixed = 16 total (was 17)
+1 💚 checkstyle 0m 32s The patch passed checkstyle in hbase-thrift
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 16m 34s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.
+1 💚 hbaseprotoc 2m 9s the patch passed
+1 💚 spotless 0m 56s patch has no errors when running spotless:check.
+1 💚 spotbugs 8m 13s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
64m 22s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5353
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux 704631e94b48 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b973ae4
Default Java Eclipse Adoptium-11.0.17+8
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/6/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/6/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@frostruan
Copy link
Contributor Author

sorry Duo, I don't know how to fix this problem .... would you mind helping me to see how to solve it ?

Thanks.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 35s Maven dependency ordering for branch
+1 💚 mvninstall 2m 41s branch-2 passed
+1 💚 compile 2m 5s branch-2 passed
+1 💚 shadedjars 5m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 25s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 33s the patch passed
+1 💚 compile 2m 5s the patch passed
+1 💚 javac 2m 5s the patch passed
+1 💚 shadedjars 5m 2s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 24s the patch passed
_ Other Tests _
+1 💚 unit 0m 30s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 8s hbase-common in the patch passed.
+1 💚 unit 8m 5s hbase-client in the patch passed.
+1 💚 unit 204m 0s hbase-server in the patch passed.
+1 💚 unit 6m 41s hbase-thrift in the patch passed.
250m 18s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux d568f034db87 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b973ae4
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/6/testReport/
Max. process+thread count 5021 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/6/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 20s branch-2 passed
+1 💚 compile 2m 4s branch-2 passed
+1 💚 shadedjars 4m 22s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 27s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 compile 2m 3s the patch passed
+1 💚 javac 2m 3s the patch passed
+1 💚 shadedjars 4m 18s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 26s the patch passed
_ Other Tests _
+1 💚 unit 0m 27s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 0s hbase-common in the patch passed.
+1 💚 unit 7m 53s hbase-client in the patch passed.
+1 💚 unit 219m 40s hbase-server in the patch passed.
+1 💚 unit 6m 58s hbase-thrift in the patch passed.
264m 1s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5353
Optional Tests javac javadoc unit shadedjars compile
uname Linux 95788cf77170 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b973ae4
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/6/testReport/
Max. process+thread count 4188 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5353/6/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Aug 28, 2023

It's OK now. The spotless result after this PR is OK. The problem is on branch-2 itself.

Let me merge.

@Apache9 Apache9 merged commit a91b870 into apache:branch-2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frostruan @Apache-HBase @Apache9